changes: add option to manage response middleware

[chemitaxis]

This PR solves this issue proposal: #531

:)

[chemitaxis]

I don't know why is failing the CI 😢 I thinks a problem installing a package:

Command failed: npm install @tanstack/svelte-query

[ymc9]

I don't know why is failing the CI 😢 I thinks a problem installing a package:

Command failed: npm install @tanstack/svelte-query

I believe it's due to the recent release of svelte V4. Please use "dev" branch as the source branch for making changes in the future, and it should work then :D.

[ymc9]

Just to make sure I understand how to use this. Since when manageCustomResponse is on the code here, simply returns the status and body, is it supposed to use the middleware like regular function call in a request handler then?

const zenstack = ZenStackMiddleware({ manageCustomResponse: true, ... });

app.all('/api/model/*', async (req, res) => {
    const { status, body } = await zenstack(req, res);
    // more processing
    ...
    return res.status(status).json(body);
});

[chemitaxis]

Hi, yes @ymc9, this is the idea but I don't know why this is not working... I have pushed a new temporal test before merging with the other express tests with manageCustomResponse: true but it's not working as expected... 🤔 the test never finish.

You can run only this test using this command from server folder

./node_modules/.bin/jest tests/adapter/express-temp.test.ts --silent=false

The silent arg is for checking console.log debugging.

I am trying to figure out where is the problem...

[ymc9]

Hey @chemitaxis

I think the problem is that when manageCustomResponse is set true, the middleware neither sends a response nor calls next(), so the processing is stuck.

I feel the general pattern of express middleware, if not sending a response, is not to return some data - I'm not sure how the returned data would be used by subsequent middleware or route handler. Instead, should it attach information to req or res object and call next(), and subsequent handlers fetch data there and decide what to do? res.locals looks like a good place to store custom data?

[chemitaxis]

Hi @ymc9 yes, exactly, there was the problem... I found it but I don't know why, I don't have notifications on my inbox when I get mentioned... I have created a test, what do you think? Best.

[rsaladocid]

this will be very useful @chemitaxis !

[ymc9]

It looks great now! I'll merge it and publish a new version soon. Thank you!