Merged
Conversation
Signed-off-by: Marcus Koh <marcus.koh@zepben.com>
Signed-off-by: Marcus Koh <marcus.koh@zepben.com>
Signed-off-by: Marcus Koh <marcus.koh@zepben.com>
Signed-off-by: Marcus Koh <marcus.koh@zepben.com>
Member
Signed-off-by: Marcus Koh <marcus.koh@zepben.com>
Signed-off-by: Marcus Koh <marcus.koh@zepben.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
See title. Also cleaned up the serialization of the config to JSON using short circuit magic.
Associated tasks
No blocking nor blocked tasks.
Test Steps
Run an intervention work package using the new config fields:
Checklist
If any of these are not applicable, strikethrough the line
~like this~. Do not delete it!. Let the reviewer decide if you should have done it.Code
- [ ] I have added/updated unit tests for these changes, and if not I have explained why they are not necessary.(tested manually)Documentation
Breaking Changes
No breaking changes---previously working work package configs will operate the same.