Skip to content

Conversation

@Esaotuelr
Copy link
Member

Description

enable span level threshold related functionality so it can be passed through to GQL call.

Associated tasks

List any other tasks / PRs that are required to be merged alongside this one (e.g. front end task for back end change or vice versa). If a PR exists, add a link. If not, just add an appropriate note here so reviewers know there is a dependency and will hold off merging until all things are ready.

Test Steps

Explain in detail how your reviewer can test the changes proposed in this PR. If it cannot be tested, leave an explanation on why.

Checklist

If any of these are not applicable, strikethrough the line ~like this~. Do not delete it!. Let the reviewer decide if you should have done it.

Code

  • I have performed a self review of my own code (including checking issues raised when creating the PR).
  • I have added/updated unit tests for these changes, and if not I have explained why they are not necessary.
  • I have commented my code in any hard-to-understand or hacky areas.
  • I have handled all new warnings generated by the compiler or IDE.
  • I have rebased onto the target branch (usually main).

Security

When developing applications, use following guidelines for information security considerations:

  • Access to applications should be protected with security keys/tokens or usernames and passwords;
  • All sessions are encrypted if possible;
  • All application input is sanitised before being acted on (ie SQL statements, etc);
  • Log messages, and especially client-facing ones, must be handled securely and must not leak credentials information (internal URLs, passwords, tokens).
  • I have considered if this change impacts information security and made sure those impacts are handled.

Documentation

  • I have updated the changelog.
    - [ ] I have updated any documentation required for these changes.

Breaking Changes

  • I have considered if this is a breaking change and will communicate it with other team members by posting it on the Slack breaking-changes channel.

Not breaking anything.

@Esaotuelr Esaotuelr requested a review from clydeu August 19, 2025 06:49
@ryanjcoleman
Copy link
Member

Task linked: DEV-3583 Update EAS Python Client

clydeu
clydeu previously approved these changes Aug 19, 2025
Copy link
Member

@clydeu clydeu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sensible. Assuming new props are already in EAS then it should be good to go.

@Esaotuelr Esaotuelr force-pushed the DEV-3583-update-for-span-level-threshold branch 2 times, most recently from 86b7dd1 to 439ba19 Compare August 26, 2025 06:11
Signed-off-by: Jimmy Tung <jimmy.tung@zepben.com>
Signed-off-by: Jimmy Tung <jimmy.tung@zepben.com>
Signed-off-by: Jimmy Tung <jimmy.tung@zepben.com>
Signed-off-by: Jimmy Tung <jimmy.tung@zepben.com>
@Esaotuelr Esaotuelr force-pushed the DEV-3583-update-for-span-level-threshold branch from 439ba19 to 892ef38 Compare September 4, 2025 06:47
Signed-off-by: Kurt Greaves <kurt.greaves@zepben.com>
@kgreav kgreav merged commit 3bfc971 into main Sep 4, 2025
4 checks passed
@kgreav kgreav deleted the DEV-3583-update-for-span-level-threshold branch September 4, 2025 07:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants