Skip to content

Conversation

@vincewhite
Copy link
Member

Description

Renamed for clarity. get_transformer_tap_settings

Associated tasks

Example:

Test Steps

Explain in detail how your reviewer can test the changes proposed in this PR. If it cannot be tested, leave an explanation on why.

Checklist

If any of these are not applicable, strikethrough the line ~like this~. Do not delete it!. Let the reviewer decide if you should have done it.

Code

  • I have performed a self review of my own code (including checking issues raised when creating the PR).
  • I have added/updated unit tests for these changes, and if not I have explained why they are not necessary.
  • I have commented my code in any hard-to-understand or hacky areas.
  • I have handled all new warnings generated by the compiler or IDE.
  • I have rebased onto the target branch (usually main).

Security

When developing applications, use following guidelines for information security considerations:

  • Access to applications should be protected with security keys/tokens or usernames and passwords;
  • All sessions are encrypted if possible;
  • All application input is sanitised before being acted on (ie SQL statements, etc);
  • Log messages, and especially client-facing ones, must be handled securely and must not leak credentials information (internal URLs, passwords, tokens).
  • I have considered if this change impacts information security and made sure those impacts are handled.

Documentation

  • I have updated the changelog.
  • I have updated any documentation required for these changes.

Breaking Changes

  • I have considered if this is a breaking change and will communicate it with other team members by posting it on the Slack breaking-changes channel.

parameter name change, any existing code calling it will need to be updated.

@ryanjcoleman
Copy link
Member

Signed-off-by: vince <vince.white@zepben.com>
Signed-off-by: vince <vince.white@zepben.com>
Signed-off-by: vince <vince.white@zepben.com>
@vincewhite vincewhite force-pushed the DEV-3832-rename_calibration_name branch from eb8a2ea to fbc3cc8 Compare August 27, 2025 06:22
@vincewhite vincewhite requested a review from chestm007 August 27, 2025 06:41
Copy link
Contributor

@chestm007 chestm007 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The things look sufficiently done

@chestm007 chestm007 merged commit 4d427ac into main Aug 27, 2025
4 checks passed
@chestm007 chestm007 deleted the DEV-3832-rename_calibration_name branch August 27, 2025 07:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants