hal: microchip: mec5: Fix bugs in EC subsystem debug enable #29
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
First, the API to enable/disable ETM debug pins was not named correctly resulting in link error. Second, the API to set the debug mode was not shifting the enum it used from the chip header file into the correct hardware register field. Signed-off-by: Scott Worley <scott.worley@microchip.com>
jvasanth1
approved these changes
Mar 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First, the API to enable/disable ETM debug pins was not named correctly resulting in link error.
Second, the API to set the debug mode was not shifting the enum it used from the chip header file into the correct hardware register field.