Skip to content

Conversation

@vtardy-st
Copy link
Contributor

@vtardy-st vtardy-st commented Oct 28, 2025

The url specified in the module.yml for the WBA6_LinkLayer15_4_Zephyr.a and WBA6_LinkLayer_Thread_lib_Zephyr.a libraries takes the main branch as reference. This url format generates a fragility about the association of zephyr and hal_stm32 to a specific historical version of the libraries. Only the last pushed version could be fetched.

In order to fix this fragility, the 'main' in the url is replaced by the SHA-1 of the commit corresponding to the version of the libraries.

Associated to issue :
#98410

Copy link
Contributor

@etienne-lms etienne-lms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Maybe add in the commit message that the change makes the reference more robust against later changes in the target repo main branch:

Replace 'main' by the SHA-1 of the commit in the URL addresses
for WBA6_LinkLayer_Thread_lib_Zephyr.a and
WBA6_LinkLayer15_4_Zephyr.a
This change increases the robustness of the reference of the
libraries to fetch against later changes in the target repo
main branch

Signed-off-by: Vincent Tardy <vincent.tardy@st.com>
@vtardy-st vtardy-st force-pushed the stm32wbax_ll_url_ref_fix branch from dcc460e to 7b2e540 Compare October 29, 2025 09:27
@mathieuchopstm
Copy link

FTR this is not strictly speaking a vulnerability as updating the blob would generate a SHA-256 mismatch, but it is for sure not correct to use a branch rather than tag/commit.

@etienne-lms
Copy link
Contributor

Indeed I agree "vulnerability" is not the right wording. "Fragility" may better apply.

@vtardy-st vtardy-st changed the title lib: blobs: fix url vulnerability for stm32wba Link Layer 802.15.4 libraries lib: blobs: fix url versioning fragility for stm32wba Link Layer 802.15.4 libraries Oct 30, 2025
@vtardy-st
Copy link
Contributor Author

Indeed I agree "vulnerability" is not the right wording. "Fragility" may better apply.

PR title changed

@erwango erwango merged commit 93e7944 into zephyrproject-rtos:main Nov 3, 2025
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants