picolibc: clang cmake fixes (for module), atomics fix, wchar_t bits #650
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Move picolibc to current main branch version as that includes fixes needed for the zephyr module when building with clang, wchar_t support in stdio and a fix for the atomics used in ungetc/getc. Signed-off-by: Keith Packard <keithp@keithp.com>
galak
approved these changes
Mar 15, 2023
keith-packard
added a commit
to keith-packard/zephyr
that referenced
this pull request
Mar 15, 2023
This updates west.yml to pull the version of picolibc that includes both the patches in zephyrproject-rtos#54391 as well as the fix providing compatibility for the 'deprecated' attribute when using GCC versions before 4.5, such as the GCC based XCC compiler. Changes for 'weak' attributes were added to avoid using inline asm statements for compilers that support the necessary attributes. This commit is synchronized with Zephyr SDK: zephyrproject-rtos/sdk-ng#650 Signed-off-by: Keith Packard <keithp@keithp.com>
dkalowsk
approved these changes
Mar 15, 2023
stephanosio
approved these changes
Mar 16, 2023
galak
pushed a commit
to zephyrproject-rtos/zephyr
that referenced
this pull request
Mar 20, 2023
This updates west.yml to pull the version of picolibc that includes both the patches in #54391 as well as the fix providing compatibility for the 'deprecated' attribute when using GCC versions before 4.5, such as the GCC based XCC compiler. Changes for 'weak' attributes were added to avoid using inline asm statements for compilers that support the necessary attributes. This commit is synchronized with Zephyr SDK: zephyrproject-rtos/sdk-ng#650 Signed-off-by: Keith Packard <keithp@keithp.com>
coreboot-bot
pushed a commit
to coreboot/zephyr-cros
that referenced
this pull request
Mar 24, 2023
This updates west.yml to pull the version of picolibc that includes both the patches in #54391 as well as the fix providing compatibility for the 'deprecated' attribute when using GCC versions before 4.5, such as the GCC based XCC compiler. Changes for 'weak' attributes were added to avoid using inline asm statements for compilers that support the necessary attributes. This commit is synchronized with Zephyr SDK: zephyrproject-rtos/sdk-ng#650 (cherry picked from commit 047ee8c) Original-Signed-off-by: Keith Packard <keithp@keithp.com> GitOrigin-RevId: 047ee8c Change-Id: I28e47a5a1a2c6089cbb4304aaaf0b7f039bd2088 Reviewed-on: https://chromium-review.googlesource.com/c/chromiumos/third_party/zephyr/+/4356817 Commit-Queue: Tristan Honscheid <honscheid@google.com> Tested-by: Tristan Honscheid <honscheid@google.com> Tested-by: CopyBot Service Account <copybot.service@gmail.com> Reviewed-by: Tristan Honscheid <honscheid@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Move picolibc to current main branch version as that includes fixes needed for the zephyr module when building with clang, wchar_t support in stdio and a fix for the atomics used in ungetc/getc.