zephyr: linker: Fix .noinit section names #100260
Open
+50
−42
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This patch just formats the section_tags.h file before the real patch, otherwise the changes would be hard to read. Signed-off-by: Marcelo Roberto Jimenez <marcelo.jimenez@gmail.com>
zephyr_code_relocate() was not working for .noinit sections. In particular, it was not relocating network buffers to other RAM areas. The __noinit macro was using quoted strings in the created section names like: .noinit."WEST_TOPDIR/path/file.c".symbol with embedded quotes. GNU ld's KEEP() directive parses quoted strings as separate tokens, causing pattern matching to fail and preventing .noinit sections from being relocated to the target memory region. The solution was to change the __noinit macro to avoid using double quotes to generate clean section names like: .noinit.WEST_TOPDIR/path/file.c.symbol Signed-off-by: Marcelo Roberto Jimenez <marcelo.jimenez@gmail.com>
|
Contributor
|
Possibly related #100221 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
zephyr_code_relocate() was not working for .noinit sections. In particular, it was not relocating network buffers to other RAM areas.
The __noinit macro was using quoted strings in the created section names like:
.noinit."WEST_TOPDIR/path/file.c".symbolwith embedded quotes.GNU ld's KEEP() directive parses quoted strings as separate tokens, causing pattern matching to fail and preventing .noinit sections from being relocated to the target memory region.
The solution was to change the __noinit macro to avoid using double quotes to generate clean section names like
.noinit.WEST_TOPDIR/path/file.c.symbol.