i2c/i3c: rtio: explicit zeroing of SQE flags #100419
Open
+5
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Explcitly zero the flags of the SQE obtained from `rtio_sqe_acquire` when the `rtio_sqe_prep_*` helpers aren't used (the helpers memset the entire struct to 0). The flags must be reset to ensure the `RTIO_SQE_TRANSACTION` and `RTIO_SQE_CHAINED` are not retained from a previous SQE. Signed-off-by: Jordan Yates <jordan@embeint.com>
|
teburd
approved these changes
Dec 3, 2025
Contributor
|
I should zero this out in acquire instead probably but felt this added a cost since it was going to almost certainly be overwritten. |
dcpleung
approved these changes
Dec 3, 2025
XenuIsWatching
approved these changes
Dec 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explcitly zero the flags of the SQE obtained from
rtio_sqe_acquirewhen thertio_sqe_prep_*helpers aren't used (the helpers memset the entire struct to 0).The flags must be reset to ensure the
RTIO_SQE_TRANSACTIONandRTIO_SQE_CHAINEDare not retained from a previous SQE.