drivers: watchdog: sf32lb: fix return errors #100778
Open
+41
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
requested review from
cameled,
gmarull,
katsuster and
martinjaeger
gmarull
reviewed
Dec 10, 2025
| return -EINVAL; | ||
| } | ||
|
|
||
| data->timeout_valid = true; |
Member
There was a problem hiding this comment.
is this ever set to false, or could be set if de-configured?
gmarull
reviewed
Dec 10, 2025
drivers/watchdog/wdt_sf32lb.c
Outdated
| } | ||
|
|
||
| if (wdt_sf32lb_is_enabled(dev)) { | ||
| LOG_ERR("Watchdog already setup"); |
Member
There was a problem hiding this comment.
Suggested change
| LOG_ERR("Watchdog already setup"); | |
| LOG_ERR("Setup not allowed with watchdog enabled"); |
gmarull
reviewed
Dec 10, 2025
Comment on lines
72
to
75
| if (!wdt_sf32lb_is_enabled(dev)) { | ||
| return -EFAULT; |
gmarull
reviewed
Dec 10, 2025
drivers/watchdog/wdt_sf32lb.c
Outdated
| struct wdt_sf32lb_data *data = dev->data; | ||
|
|
||
| if (wdt_sf32lb_is_enabled(dev)) { | ||
| LOG_ERR("Watchdog already setup"); |
Member
There was a problem hiding this comment.
Suggested change
| LOG_ERR("Watchdog already setup"); | |
| LOG_ERR("Timeout install not allowed with watchdog enabled"); |
Fix watchdog driver return error Signed-off-by: Qingsong Gou <gouqs@hotmail.com>
gmarull
approved these changes
Dec 10, 2025
|
fabiobaltieri
approved these changes
Dec 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix watchdog driver return error