cmake: hwmv2: optimize list_hardware.py output parsing #100804
+8
−10
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Replace inefficient string parsing loop with CMake list iteration for processing list_hardware.py output. The previous implementation used repeated string operations on the entire output string for each line, which is increasingly slow as hardware list grows. Local tests show hwmv2.cmake module loading in ~350 ms instead of 540 ms on my machine. Signed-off-by: Benjamin Cabé <benjamin@zephyrproject.org>
zephyrbot
requested review from
57300,
jeremybettis,
nashif,
nordicjm and
tejlmand
kartben
changed the title
|
teburd
approved these changes
Dec 10, 2025
nordicjm
approved these changes
Dec 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace inefficient string parsing loop with CMake list iteration for processing list_hardware.py output. The previous implementation used repeated string operations on the entire output string for each line, which is increasingly slow as hardware list grows...
Local tests show hwmv2.cmake module loading in ~350 ms instead of 540 ms on my machine.