pmci: mctp: samples: Remove unnecessary include #100831
Merged
+0
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These samples do not seem to need the unistd.h header, but including it limits us to C libraries which have it, which as it is a POSIX extension is not all. So let's not include it so we do not limit ourselves unnecessarily. Signed-off-by: Alberto Escolar Piedras <alberto.escolar.piedras@nordicsemi.no>
aescolar
added
the
Trivial
zephyrbot
added
area: Samples
teburd
approved these changes
Dec 10, 2025
|
kartben
approved these changes
Dec 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
These samples do not seem to need the unistd.h header, but including it limits us to C libraries which have it, which, as it is a POSIX extension, is not all.
So let's not include it so we do not limit ourselves unnecessarily.
Without this fix building with a C library without this header would result on:
With this fix all these samples build fine with libraries without it (like w
CONFIG_MINIMAL_LIBC=y)