[RFC] ST sensor drivers migration to STdC #14111

avisconti · 2019-03-06T16:12:12Z

STdC is a standard package written by ST that aims to provide a standard register i/f for ST MEMS
sensors. It is already offered/used in other s/w systems as well.
The idea behind it is to have a clean and stable functions/defines to read/write sensors registers.
Official public repo is:
https://github.com/STMicroelectronics/STMems_Standard_C_drivers

The license seems to be the same as stm32cube, so there should be no issues here.
Since STdC package is including math.h I had to enable NEWLIB_LIBC.

In this RFC I did an experimental test using lis2dw12 driver. It works for both i2c and spi.
Please provide your feedback.

zephyrbot · 2019-03-06T16:21:08Z

Found the following issues, please fix and resubmit:

License issues

In most cases you do not need to do anything here, especially if the files
reported below are going into ext/ and if license was approved for inclusion
into ext/ already. Fix any missing license/copyright issues. The license
exception if a JFYI for the maintainers and can be overriden when merging the
pull request.

ext/hal/st/stmemsc/a3g4250d_STdC/driver/a3g4250d_reg.c is not apache-2.0 licensed: bsd-new
ext/hal/st/stmemsc/a3g4250d_STdC/driver/a3g4250d_reg.h is not apache-2.0 licensed: bsd-new
ext/hal/st/stmemsc/ais328dq_STdC/driver/ais328dq_reg.c is not apache-2.0 licensed: bsd-new
ext/hal/st/stmemsc/ais328dq_STdC/driver/ais328dq_reg.h is not apache-2.0 licensed: bsd-new
ext/hal/st/stmemsc/ais3624dq_STdC/driver/ais3624dq_reg.c is not apache-2.0 licensed: bsd-new
ext/hal/st/stmemsc/ais3624dq_STdC/driver/ais3624dq_reg.h is not apache-2.0 licensed: bsd-new
ext/hal/st/stmemsc/asm330lhh_STdC/driver/asm330lhh_reg.c is not apache-2.0 licensed: bsd-new
ext/hal/st/stmemsc/asm330lhh_STdC/driver/asm330lhh_reg.h is not apache-2.0 licensed: bsd-new
ext/hal/st/stmemsc/h3lis331dl_STdC/driver/h3lis331dl_reg.c is not apache-2.0 licensed: bsd-new
ext/hal/st/stmemsc/h3lis331dl_STdC/driver/h3lis331dl_reg.h is not apache-2.0 licensed: bsd-new
ext/hal/st/stmemsc/hts221_STdC/driver/hts221_reg.c is not apache-2.0 licensed: bsd-new
ext/hal/st/stmemsc/hts221_STdC/driver/hts221_reg.h is not apache-2.0 licensed: bsd-new
ext/hal/st/stmemsc/i3g4250d_STdC/driver/i3g4250d_reg.c is not apache-2.0 licensed: bsd-new
ext/hal/st/stmemsc/i3g4250d_STdC/driver/i3g4250d_reg.h is not apache-2.0 licensed: bsd-new
ext/hal/st/stmemsc/iis2dh_STdC/driver/iis2dh_reg.c is not apache-2.0 licensed: bsd-new
ext/hal/st/stmemsc/iis2dh_STdC/driver/iis2dh_reg.h is not apache-2.0 licensed: bsd-new
ext/hal/st/stmemsc/iis2dlpc_STdC/driver/iis2dlpc_reg.c is not apache-2.0 licensed: bsd-new
ext/hal/st/stmemsc/iis2dlpc_STdC/driver/iis2dlpc_reg.h is not apache-2.0 licensed: bsd-new
ext/hal/st/stmemsc/iis2mdc_STdC/driver/iis2mdc_reg.c is not apache-2.0 licensed: bsd-new
ext/hal/st/stmemsc/iis2mdc_STdC/driver/iis2mdc_reg.h is not apache-2.0 licensed: bsd-new
ext/hal/st/stmemsc/iis328dq_STdC/driver/iis328dq_reg.c is not apache-2.0 licensed: bsd-new
ext/hal/st/stmemsc/iis328dq_STdC/driver/iis328dq_reg.h is not apache-2.0 licensed: bsd-new
ext/hal/st/stmemsc/iis3dhhc_STdC/driver/iis3dhhc_reg.c is not apache-2.0 licensed: bsd-new
ext/hal/st/stmemsc/iis3dhhc_STdC/driver/iis3dhhc_reg.h is not apache-2.0 licensed: bsd-new
ext/hal/st/stmemsc/ism303dac_STdC/driver/ism303dac_reg.c is not apache-2.0 licensed: bsd-new
ext/hal/st/stmemsc/ism303dac_STdC/driver/ism303dac_reg.h is not apache-2.0 licensed: bsd-new
ext/hal/st/stmemsc/ism330dlc_STdC/driver/ism330dlc_reg.c is not apache-2.0 licensed: bsd-new
ext/hal/st/stmemsc/ism330dlc_STdC/driver/ism330dlc_reg.h is not apache-2.0 licensed: bsd-new
ext/hal/st/stmemsc/l20g20is_STdC/driver/l20g20is_reg.c is not apache-2.0 licensed: bsd-new
ext/hal/st/stmemsc/l20g20is_STdC/driver/l20g20is_reg.h is not apache-2.0 licensed: bsd-new
ext/hal/st/stmemsc/lis2de12_STdC/driver/lis2de12_reg.c is not apache-2.0 licensed: bsd-new
ext/hal/st/stmemsc/lis2de12_STdC/driver/lis2de12_reg.h is not apache-2.0 licensed: bsd-new
ext/hal/st/stmemsc/lis2dh12_STdC/driver/lis2dh12_reg.c is not apache-2.0 licensed: bsd-new
ext/hal/st/stmemsc/lis2dh12_STdC/driver/lis2dh12_reg.h is not apache-2.0 licensed: bsd-new
ext/hal/st/stmemsc/lis2ds12_STdC/driver/lis2ds12_reg.c is not apache-2.0 licensed: bsd-new
ext/hal/st/stmemsc/lis2ds12_STdC/driver/lis2ds12_reg.h is not apache-2.0 licensed: bsd-new
ext/hal/st/stmemsc/lis2dw12_STdC/driver/lis2dw12_reg.c is not apache-2.0 licensed: bsd-new
ext/hal/st/stmemsc/lis2dw12_STdC/driver/lis2dw12_reg.h is not apache-2.0 licensed: bsd-new
ext/hal/st/stmemsc/lis2hh12_STdC/driver/lis2hh12_reg.c is not apache-2.0 licensed: bsd-new
ext/hal/st/stmemsc/lis2hh12_STdC/driver/lis2hh12_reg.h is not apache-2.0 licensed: bsd-new
ext/hal/st/stmemsc/lis2mdl_STdC/driver/lis2mdl_reg.c is not apache-2.0 licensed: bsd-new
ext/hal/st/stmemsc/lis2mdl_STdC/driver/lis2mdl_reg.h is not apache-2.0 licensed: bsd-new
ext/hal/st/stmemsc/lis331dlh_STdC/driver/lis331dlh_reg.c is not apache-2.0 licensed: bsd-new
ext/hal/st/stmemsc/lis331dlh_STdC/driver/lis331dlh_reg.h is not apache-2.0 licensed: bsd-new
ext/hal/st/stmemsc/lis3de_STdC/driver/lis3de_reg.c is not apache-2.0 licensed: bsd-new
ext/hal/st/stmemsc/lis3de_STdC/driver/lis3de_reg.h is not apache-2.0 licensed: bsd-new
ext/hal/st/stmemsc/lis3dh_STdC/driver/lis3dh_reg.c is not apache-2.0 licensed: bsd-new
ext/hal/st/stmemsc/lis3dh_STdC/driver/lis3dh_reg.h is not apache-2.0 licensed: bsd-new
ext/hal/st/stmemsc/lis3dhh_STdC/driver/lis3dhh_reg.c is not apache-2.0 licensed: bsd-new
ext/hal/st/stmemsc/lis3dhh_STdC/driver/lis3dhh_reg.h is not apache-2.0 licensed: bsd-new
ext/hal/st/stmemsc/lis3mdl_STdC/driver/lis3mdl_reg.c is not apache-2.0 licensed: bsd-new
ext/hal/st/stmemsc/lis3mdl_STdC/driver/lis3mdl_reg.h is not apache-2.0 licensed: bsd-new
ext/hal/st/stmemsc/lps22hb_STdC/driver/lps22hb_reg.c is not apache-2.0 licensed: bsd-new
ext/hal/st/stmemsc/lps22hb_STdC/driver/lps22hb_reg.h is not apache-2.0 licensed: bsd-new
ext/hal/st/stmemsc/lps22hh_STdC/driver/lps22hh_reg.c is not apache-2.0 licensed: bsd-new
ext/hal/st/stmemsc/lps22hh_STdC/driver/lps22hh_reg.h is not apache-2.0 licensed: bsd-new
ext/hal/st/stmemsc/lps25hb_STdC/driver/lps25hb_reg.c is not apache-2.0 licensed: bsd-new
ext/hal/st/stmemsc/lps25hb_STdC/driver/lps25hb_reg.h is not apache-2.0 licensed: bsd-new
ext/hal/st/stmemsc/lps33hw_STdC/driver/lps33hw_reg.c is not apache-2.0 licensed: bsd-new
ext/hal/st/stmemsc/lps33hw_STdC/driver/lps33hw_reg.h is not apache-2.0 licensed: bsd-new
ext/hal/st/stmemsc/lsm303agr_STdC/driver/lsm303agr_reg.c is not apache-2.0 licensed: bsd-new
ext/hal/st/stmemsc/lsm303agr_STdC/driver/lsm303agr_reg.h is not apache-2.0 licensed: bsd-new
ext/hal/st/stmemsc/lsm303ah_STdC/driver/lsm303ah_reg.c is not apache-2.0 licensed: bsd-new
ext/hal/st/stmemsc/lsm303ah_STdC/driver/lsm303ah_reg.h is not apache-2.0 licensed: bsd-new
ext/hal/st/stmemsc/lsm6ds3_STdC/driver/lsm6ds3_reg.c is not apache-2.0 licensed: bsd-new
ext/hal/st/stmemsc/lsm6ds3_STdC/driver/lsm6ds3_reg.h is not apache-2.0 licensed: bsd-new
ext/hal/st/stmemsc/lsm6dsl_STdC/driver/lsm6dsl_reg.c is not apache-2.0 licensed: bsd-new
ext/hal/st/stmemsc/lsm6dsl_STdC/driver/lsm6dsl_reg.h is not apache-2.0 licensed: bsd-new
ext/hal/st/stmemsc/lsm6dsm_STdC/driver/lsm6dsm_reg.c is not apache-2.0 licensed: bsd-new
ext/hal/st/stmemsc/lsm6dsm_STdC/driver/lsm6dsm_reg.h is not apache-2.0 licensed: bsd-new
ext/hal/st/stmemsc/lsm6dso_STdC/driver/lsm6dso_reg.c is not apache-2.0 licensed: bsd-new
ext/hal/st/stmemsc/lsm6dso_STdC/driver/lsm6dso_reg.h is not apache-2.0 licensed: bsd-new
ext/hal/st/stmemsc/lsm6dso_STdC/lib/fifo_utility/fifo_utility.c is not apache-2.0 licensed: bsd-new
ext/hal/st/stmemsc/lsm6dso_STdC/lib/fifo_utility/fifo_utility.h is not apache-2.0 licensed: bsd-new
ext/hal/st/stmemsc/lsm6dsox_STdC/driver/lsm6dsox_reg.c is not apache-2.0 licensed: bsd-new
ext/hal/st/stmemsc/lsm6dsox_STdC/driver/lsm6dsox_reg.h is not apache-2.0 licensed: bsd-new
ext/hal/st/stmemsc/lsm6dsox_STdC/lib/fifo_utility/fifo_utility.c is not apache-2.0 licensed: bsd-new
ext/hal/st/stmemsc/lsm6dsox_STdC/lib/fifo_utility/fifo_utility.h is not apache-2.0 licensed: bsd-new
ext/hal/st/stmemsc/lsm9ds1_STdC/driver/lsm9ds1_reg.c is not apache-2.0 licensed: bsd-new
ext/hal/st/stmemsc/lsm9ds1_STdC/driver/lsm9ds1_reg.h is not apache-2.0 licensed: bsd-new
ext/hal/st/stmemsc/stts751_STdC/driver/stts751_reg.c is not apache-2.0 licensed: bsd-new
ext/hal/st/stmemsc/stts751_STdC/driver/stts751_reg.h is not apache-2.0 licensed: bsd-new

avisconti · 2019-03-11T12:55:01Z

@erwango
This is not urgent as I'm planning it for v1.15, but would be great to receive your feedback
for the 'ext/' part as soon as possible. If it makes sense to proceed with this standard sensor reg i/f
drivers I have some porting work to do.

avisconti · 2019-03-11T13:11:15Z

@MaureenHelm
I would like to seek your opinion as well.

avisconti · 2019-04-12T14:17:20Z

@erwango @MaureenHelm
I re-aligned to latest commit and re-pushed.
As I was saying this RFC is quite important for me, as if accepted I would need to make modifications
to #13062 and to #13478 outstanding PR.

erwango

Few comments on packages integration, otherwise looks good.

erwango · 2019-04-23T13:56:08Z

ext/hal/st/stmemsc/README

I think this Licence agreement is raising concerns.
I don't know how compatible is the use of SLA with Zephyr policy. As far as I understand, using this package binds to agree these terms, not sure how it fits with Apache 2.0 (is that strictly orthogonal)?
Is that SLA strictly needed?

We have the same agreement cited in all stm32cube packages, like ext/hal/st/stm32cube/stm32f4xx/README for example.

Why should be an issue here?

Right, let me sort this out.

@avisconti , I'm updating the link for Cube packages: #15731

@avisconti , I'm updating the link for Cube packages: #15731

OK, I'm going to change it as well. Thx!

erwango · 2019-04-23T13:57:38Z

ext/hal/st/stmemsc/README.md

Should this file be kept as is?
As I understand you stripped from the initial package structure and some parts of this README aren't valid.

Correct! I removed all the examples. So I will strip off from the README.md all references to examples.

erwango · 2019-04-23T13:58:55Z

ext/hal/st/stmemsc/a3g4250d_STdC/README.txt

Same here, should we keep those?

Mmmmh ok.
So I see two options now. Either keeping also the examples in the package or adapting all the README (but there are many) stripping of all references to examples.

@erwango
If you don't see issues I may go with option one which seems to be less impacting.

I'm not sure adding examples juts because README files refer to it is a great option.
Do we really need these README files at all?
I don't see much added value in the information provided, this is only copy/paste from one to the other, and most of the information is not valid as referring to examples that you initially considered as superfluous (and I think you were right).
The only interesting information that differ from one file to the other is H3LIS331DL DS rev3.0 , which could be factorized in a upper file if needed.

So, your preferred option would be:

Package w/o examples

Remove all README files under drivers

Keep the top README file w/o reference to example

Correct?
I'm ok with it. The only thing is that everytime I have to re-align the package there is an
extra effort (but not that much) to clean the package up.

This is indeed indeed my preferred way to do it.
For the extra pain to do it, I suggest to spend few hours on a script to do it for you.
I have this for cube packages update and this saves me painful hours each time.

avisconti · 2019-04-24T13:11:34Z

rebased and repushed as agreed with @erwango

avisconti · 2019-04-24T13:41:59Z

@erwango
It seems that you are in charge of everything under ext/hal/st.
This will include also stmemsc.

avisconti · 2019-04-24T15:20:01Z

I got now that I have to solve a couple of false postives in UNDEF_KCONFIG_WHITELIST.
:-(

erwango · 2019-04-29T07:40:09Z

@erwango
It seems that you are in charge of everything under ext/hal/st.
This will include also stmemsc.

@avisconti, as discussed, can you add your name in front of stmemsc in CODEOWNER?

avisconti · 2019-04-29T08:09:05Z

@avisconti, as discussed, can you add your name in front of stmemsc in CODEOWNER?

Yes I did.
It is in 52bc149 commit. Is it not matching your expectation? If I remember well we concluded
to have the 'backup' line (i.e. /ext/hal/st) first and then the line for stmemsc, correct?

Now I made a change in the ci-tools whitelist in order to have the CI passing for this PR.

erwango · 2019-04-29T08:23:04Z

It is in 52bc149 commit. Is it not matching your expectation?

It's perfect, much more than my monday eyes.

avisconti · 2019-05-02T10:00:48Z

@erwango @galak
I see that now the CI is giving an issue when running tests. The issue is that to properly compile we
need to define following macros:

CONFIG_NEWLIB_LIBC=y
CONFIG_NEWLIB_LIBC_FLOAT_PRINTF=y

Before I used 'select' directly in stmemsc Kconfig file, but I saw that usage of 'select' for visible
symbols (the ones with a prompt) is not recommended. So, I recently changed it in this PR avoiding
'select' and using instead 'depends on'. But this requires the symbols to be defined somewhere during
CI test. I have now two options:

Going back to using 'select'
Defining somewhere the two symbols. Maybe in sensors_i_z.conf (and all other sensors conf files)
but this would impact other sensors too.

So, can you help me in using the right approach for fixing CI?

EDIT:
Maybe also @MaureenHelm may add some comments.

EDIT2:
It seems that there is a third options discussed with @MaureenHelm, which is to add a new test
for sensor using the new stmemsc external hal, where I can define a separate conf file.

galak · 2019-05-02T14:32:03Z

@erwango @galak
I see that now the CI is giving an issue when running tests. The issue is that to properly compile we
need to define following macros:

CONFIG_NEWLIB_LIBC=y
CONFIG_NEWLIB_LIBC_FLOAT_PRINTF=y

Before I used 'select' directly in stmemsc Kconfig file, but I saw that usage of 'select' for visible
symbols (the ones with a prompt) is not recommended. So, I recently changed it in this PR avoiding
'select' and using instead 'depends on'. But this requires the symbols to be defined somewhere during
CI test. I have now two options:

Going back to using 'select'

Defining somewhere the two symbols. Maybe in sensors_i_z.conf (and all other sensors conf files)
but this would impact other sensors too.

So, can you help me in using the right approach for fixing CI?

EDIT:
Maybe also @MaureenHelm may add some comments.

EDIT2:
It seems that there is a third options discussed with @MaureenHelm, which is to add a new test
for sensor using the new stmemsc external hal, where I can define a separate conf file.

So I think you should have a separate test for this if newlib is required for the sensor drivers. We shouldn't burden sensors_i_z.conf with that requirement.

If that makes its easier to use 'depends' than great. However, I'd try 'imply' and see how that works.

avisconti · 2019-05-02T16:55:00Z

re-pushed again
Now I'm using 'imply' inside the stmemsc Kconfig.
Moreover I defined two new sensor tests for LIS2DW12: test_build_sensors_stmemsc and test_build_sensors_stmemsc_trigger.
All ST sensors that will make use of stmemsc hal in the future will be put inside this test.

avisconti · 2019-05-03T07:15:16Z

@erwango @MaureenHelm
Not sure what the Codeowners failed check is about, the details are not clear enough.

I think the code now is in a good shape, isn't it?

erwango · 2019-05-06T08:05:40Z

@avisconti , seems there was an issue in CODEOWNER file that prevented correct parsing.
It is fixed now. Can you rebase to take fix into account and see if fixing you issue?

avisconti · 2019-05-06T08:25:17Z

@avisconti , seems there was an issue in CODEOWNER file that prevented correct parsing.
It is fixed now. Can you rebase to take fix into account and see if fixing you issue?

OK, thx!
re-pushed! Let's see how it goes now.

avisconti · 2019-05-08T08:45:13Z

@MaureenHelm
What's ur opinion about introducing the STdC HAL i/f?
If you approve I can later go further porting also LPS22HH and LSM6DSO on it.
Thx!

Added: CONFIG_LSM6DSO_INT_PIN CONFIG_PEDO_THS_MIN CONFIG_USE_STDC_ Referenced in PR zephyrproject-rtos#14111 and PR zephyrproject-rtos#15425. Signed-off-by: Armando Visconti <armando.visconti@st.com>

avisconti · 2019-05-22T13:10:42Z

@galak @MaureenHelm
Anything else recommended in this PR?

avisconti · 2019-05-27T07:13:25Z

@erwango
Can you confirm again the license (BSD-3-Clause) is not an issue?
I think it is the same as STM32cube, right?

erwango · 2019-05-27T08:37:18Z

@avisconti , BSD-3 Clause is fine, sure.
Though, there is a indeed a shade vs Apache which is too subtle for the License bot to handle. This is hence up to the maintainer to ack.

erwango · 2019-06-06T07:26:36Z

@nashif, do you want to merge this one now? or latter once the modules are there?

This package contains platform independent drivers written in C language for STMicroelectronics sensors. The aim of this package is to provide a common, clean and stable interface to access sensor registers. Library is located in ext/hal/st/stmemsc/ Origin: ST Microelectronics License: BSD-3-Clause URL: https://www.st.com/en/embedded-software/c-driver-mems.html Commit: v1.00 Purpose: provide a common and stable i/f to access sensor registers Maintained-by: ST Microelectronics Signed-off-by: Armando Visconti <armando.visconti@st.com>

Port the lis2dw12 sensor driver on top of the lis2dw12_StdC HAL interface (under ext/hal/st/stmemsc/). Signed-off-by: Armando Visconti <armando.visconti@st.com>

avisconti · 2019-06-06T13:43:49Z

@nashif @erwango
I rebased this PR on the latest code.
Moreover I changed the ext/hal/st/stmemsc/Kconfig file with two simple changes:

I added the USE symbols for all drivers (before was only lis2dw12)
I removed the prompt from the USE symbols, as we want to force them from the KConfig of each specific driver.

avisconti · 2019-06-20T08:28:57Z

@nashif @erwango
I moved the STdC in hal_st module. I'm going to close this PR.
The lis2dw12 porting on top of STdC HAL i/f will be resubmitted as a new PR later on.
(see zephyrproject-rtos/hal_st#1)

Added: CONFIG_LSM6DSO_INT_PIN CONFIG_PEDO_THS_MIN CONFIG_USE_STDC_ Referenced in PR zephyrproject-rtos#14111 and PR zephyrproject-rtos#15425. Signed-off-by: Armando Visconti <armando.visconti@st.com>

avisconti added area: Sensors Sensors RFC Request For Comments: want input from the community labels Mar 6, 2019

avisconti self-assigned this Mar 6, 2019

avisconti requested review from MaureenHelm, erwango and galak March 6, 2019 16:12

avisconti changed the title ~~ST sensor drivers migration to STdC~~ [RFC] ST sensor drivers migration to STdC Mar 6, 2019

avisconti force-pushed the lis2dw12-pid-migration branch 4 times, most recently from 2a83d6c to 992840e Compare March 11, 2019 12:35

avisconti force-pushed the lis2dw12-pid-migration branch from 992840e to 5d885d7 Compare March 12, 2019 08:21

avisconti added this to the v1.15.0 milestone Mar 14, 2019

avisconti force-pushed the lis2dw12-pid-migration branch from 5d885d7 to 7f1c632 Compare April 12, 2019 14:04

erwango requested changes Apr 23, 2019

View reviewed changes

avisconti force-pushed the lis2dw12-pid-migration branch from 7f1c632 to a3b9082 Compare April 24, 2019 13:10

avisconti mentioned this pull request Apr 24, 2019

lis2dw12: add Single/Double Tap triggers #13573

Closed

avisconti force-pushed the lis2dw12-pid-migration branch 2 times, most recently from 31fe99b to 91d7221 Compare April 24, 2019 15:08

avisconti mentioned this pull request Apr 29, 2019

Add vl53l1x support #15566

Closed

avisconti force-pushed the lis2dw12-pid-migration branch from c79dfaa to 0f61a46 Compare April 30, 2019 16:06

avisconti force-pushed the lis2dw12-pid-migration branch 2 times, most recently from 8d3d81b to 5e840d0 Compare May 2, 2019 16:52

avisconti mentioned this pull request May 3, 2019

drivers/i2s_ll_stm32.c: (FIX) Avoid warning in LOG_ERR #15857

Merged

avisconti force-pushed the lis2dw12-pid-migration branch from 5e840d0 to 86c0474 Compare May 6, 2019 08:20

avisconti requested a review from nashif as a code owner May 6, 2019 08:20

erwango approved these changes May 7, 2019

View reviewed changes

erwango mentioned this pull request May 10, 2019

ext: st: move ST HAL to its own repo #16044

Closed

avisconti added 2 commits June 6, 2019 15:37

driver/sensor: lis2dw12: make use of STdC definitions

dd087be

Port the lis2dw12 sensor driver on top of the lis2dw12_StdC HAL interface (under ext/hal/st/stmemsc/). Signed-off-by: Armando Visconti <armando.visconti@st.com>

avisconti force-pushed the lis2dw12-pid-migration branch from 86c0474 to dd087be Compare June 6, 2019 13:40

avisconti closed this Jun 20, 2019

avisconti deleted the lis2dw12-pid-migration branch June 27, 2019 06:56

Uh oh!

[RFC] ST sensor drivers migration to STdC #14111

[RFC] ST sensor drivers migration to STdC #14111

Uh oh!

Conversation

avisconti commented Mar 6, 2019

Uh oh!

zephyrbot commented Mar 6, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

License issues

Uh oh!

avisconti commented Mar 11, 2019

Uh oh!

avisconti commented Mar 11, 2019

Uh oh!

avisconti commented Apr 12, 2019

Uh oh!

erwango left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

avisconti Apr 24, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

avisconti commented Apr 24, 2019

Uh oh!

avisconti commented Apr 24, 2019

Uh oh!

avisconti commented Apr 24, 2019

Uh oh!

erwango commented Apr 29, 2019

Uh oh!

avisconti commented Apr 29, 2019

Uh oh!

erwango commented Apr 29, 2019

Uh oh!

avisconti commented May 2, 2019 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

galak commented May 2, 2019

Uh oh!

avisconti commented May 2, 2019

Uh oh!

avisconti commented May 3, 2019

Uh oh!

erwango commented May 6, 2019

Uh oh!

avisconti commented May 6, 2019

Uh oh!

avisconti commented May 8, 2019

Uh oh!

avisconti commented May 22, 2019

Uh oh!

avisconti commented May 27, 2019

Uh oh!

erwango commented May 27, 2019

Uh oh!

erwango commented Jun 6, 2019

zephyrbot commented Mar 6, 2019 •

edited

Loading

avisconti Apr 24, 2019 •

edited

Loading

avisconti commented May 2, 2019 •

edited

Loading

avisconti commented Jun 20, 2019 •

edited

Loading