Skip to content

Conversation

@erwango
Copy link
Member

@erwango erwango commented Mar 22, 2019

2 identical packages were defined for stm32f412 SoC, invariant "g".
Merge them in new sinclge stm32f412Xg.dtsi.
Update matching boards accordinlgy.

Signed-off-by: Erwan Gouriou erwan.gouriou@linaro.org

@erwango erwango added this to the v1.15.0 milestone Mar 22, 2019
@erwango erwango requested a review from galak March 22, 2019 13:19
@erwango erwango requested a review from avisconti as a code owner March 22, 2019 13:19
@codecov-io
Copy link

Codecov Report

Merging #14839 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master   #14839   +/-   ##
=======================================
  Coverage   52.49%   52.49%           
=======================================
  Files         309      309           
  Lines       45060    45060           
  Branches    10431    10431           
=======================================
  Hits        23656    23656           
  Misses      16592    16592           
  Partials     4812     4812

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 66d339a...d21a849. Read the comment docs.

Copy link
Contributor

@avisconti avisconti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, basically there was dts definition for both f412cg and f412zg. So you just defined one (f412Xg).
Seems legit.

2 identical packages were defined for stm32f412 SoC, invariant "g".
Merge them in new sinclge stm32f412Xg.dtsi.
Update matching boards accordinlgy.

Signed-off-by: Erwan Gouriou <erwan.gouriou@linaro.org>
@galak galak force-pushed the fix_stm32f412_packages branch from d21a849 to 4daad6f Compare April 17, 2019 20:20
@nashif nashif merged commit 08d41ec into zephyrproject-rtos:master Apr 18, 2019
@erwango erwango deleted the fix_stm32f412_packages branch September 3, 2019 12:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants