samples: rtu_server: add support for CDC ACM UART #47514
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We cannot implement configure API because there is no notification of configuration changes provided for the Abstract Control Model and the UART controller is only emulated. However, it allows us to use CDC ACM UART together with subsystems like Modbus which require configure API for real controllers. Signed-off-by: Johann Fischer <johann.fischer@nordicsemi.no>
Node is not a bus controller, use DT_INST_PARENT instead of DT_INST_BUS. Signed-off-by: Johann Fischer <johann.fischer@nordicsemi.no>
jfischer-no
added
area: USB
jfischer-no
requested review from
anangl,
carlescufi,
henrikbrixandersen and
mbolivar-nordic
aurel32
reviewed
Jul 9, 2022
Contributor
aurel32
left a comment
aurel32
left a comment
There was a problem hiding this comment.
Other than that overlay-cdc-acm.conf issue, that looks good to me.
Contributor
There was a problem hiding this comment.
Why is that needed? The shell is not activated in this sample, causing a warning:
warning: SHELL_BACKEND_SERIAL_CHECK_DTR (defined at subsys/shell/backends/Kconfig.backends:75) was
assigned the value 'y' but got the value 'n'. Check these unsatisfied dependencies:
SHELL_BACKEND_SERIAL (=n), SHELL_BACKENDS (=n), SHELL (=n). See
http://docs.zephyrproject.org/latest/kconfig.html#CONFIG_SHELL_BACKEND_SERIAL_CHECK_DTR and/or look
up SHELL_BACKEND_SERIAL_CHECK_DTR in the menuconfig/guiconfig interface. The Application Development
Primer, Setting Configuration Values, and Kconfig - Tips and Best Practices sections of the manual
might be helpful too.
Contributor
Author
There was a problem hiding this comment.
Thanks for the hint. It is copy&paste error (config overlay from samples/subsys/shell/shell_module).
jfischer-no
force-pushed
the
pr-cdc-acm-add-configure
branch
from
1a0624f to
37a2f00
Compare
Allow to use RTU server sample on any board that has supported USB device controller. Although it is only a point to point connection and does not represent a bus, it can, apart from testing the server implementation, also be used practically for example to control relays or to read ADC values via USB connection without implementing custom USB class or driver. Signed-off-by: Johann Fischer <johann.fischer@nordicsemi.no>
jfischer-no
force-pushed
the
pr-cdc-acm-add-configure
branch
from
37a2f00 to
34cd8cd
Compare
aurel32
approved these changes
Jul 12, 2022
Contributor
aurel32
left a comment
aurel32
left a comment
There was a problem hiding this comment.
Thanks for the update, LGTM
anangl
approved these changes
Jul 13, 2022
carlescufi
approved these changes
Jul 13, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allow to use RTU server sample on any board that has supported
USB device controller. Although it is only a point to point
connection and does not represent a bus, it can, apart from
testing the server implementation, also be used practically
for example to control relays or to read ADC values via
USB connection without implementing custom USB class or driver.
Resolves: #45938