ARC: Check that ISR and exception stacks are proper aligned #49063
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
evgeniy-paltsev
changed the title
evgeniy-paltsev
force-pushed
the
rff-stack-align-assert-v0
branch
from
07fd73c to
0639085
Compare
stephanosio
reviewed
Aug 15, 2022
CONFIG_ISR_STACK_SIZE and CONFIG_ARC_EXCEPTION_STACK_SIZE are used in arc asembler code without C wrapper on them with following manner: ---------------------------->8---------------------------- /#define INIT_STACK z_interrupt_stacks /#define INIT_STACK_SIZE CONFIG_ISR_STACK_SIZE mov_s sp, INIT_STACK add sp, sp, INIT_STACK_SIZE ---------------------------->8---------------------------- In result we can get stack unaligned if we have CONFIG_ISR_STACK_SIZE or CONFIG_ARC_EXCEPTION_STACK_SIZE values unaligned. There is no point to have unaligned stack size - so let's check against such configurations in compile time. Signed-off-by: Evgeniy Paltsev <PaltsevEvgeniy@gmail.com> Signed-off-by: Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>
evgeniy-paltsev
force-pushed
the
rff-stack-align-assert-v0
branch
from
0639085 to
95df348
Compare
ruuddw
approved these changes
Aug 15, 2022
abrodkin
approved these changes
Aug 15, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CONFIG_ISR_STACK_SIZEandCONFIG_ARC_EXCEPTION_STACK_SIZEare used in arc asembler code without C wrapper on them with following manner:In result we can get stack unaligned if we have
CONFIG_ISR_STACK_SIZEorCONFIG_ARC_EXCEPTION_STACK_SIZEvalues unaligned.
There is no point to have unaligned stack size - so let's check against such configurations in compile time.
Fixes: #37704