Bluetooth: Controller: Fix leak in Num Completed Packets and ISO Broadcast of multiple streams #50126
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix a leak in generation of Number of Completed Packets when more than one handle has acknowledgements to be processed. The loop exited for the current handle by dequeueing the node tx element of the next handle leading to lost Number of Completed Packets. Signed-off-by: Vinayak Kariappa Chettimada <vich@nordicsemi.no>
Restrict the calculated possible Pre-Transmission subevents count to a maximum of 1 so that the full ISO interval is not fully occupied by the BIG event. Signed-off-by: Vinayak Kariappa Chettimada <vich@nordicsemi.no>
Fix ISO broadcast implementation to flush stale ISO data for all BIS streams and like wise generate acknowledgements for all BIS streams that had its ISO data transmitted at its reference anchor points. Signed-off-by: Vinayak Kariappa Chettimada <vich@nordicsemi.no>
Fix missing implementation to correctly to use data channel index for subevents when previous subevent of previous BIS stream where skipped. Signed-off-by: Vinayak Kariappa Chettimada <vich@nordicsemi.no>
Initialize the invalid ISO data packet generated by LLL. Signed-off-by: Vinayak Kariappa Chettimada <vich@nordicsemi.no>
cvinayak
force-pushed
the
github_iso_broadcast_fix
branch
from
b329fcd to
d06e2f4
Compare
Fix missing Broadcast ISO Synchronized Receiver terminate reason initialization that caused Sync Lost immediately on a new Sync Establishment due to previous Sync terminate reason not being reset. Signed-off-by: Vinayak Kariappa Chettimada <vich@nordicsemi.no>
cvinayak
force-pushed
the
github_iso_broadcast_fix
branch
from
d06e2f4 to
9eabe4f
Compare
Fix incorrect use of stream index (application selected list of BIS stream) instead of BIS index when checking for whether the received PDU is to be stored and to be dispatched as ISO data to ULL. Signed-off-by: Vinayak Kariappa Chettimada <vich@nordicsemi.no>
Add 'U' to a value when assigning it to an unsigned variable. MISRA-C rule 7.2 Relates to commit b97db52 ("misra-c: Add 'U' to unsigned variable assignments in subsys/"). Signed-off-by: Vinayak Kariappa Chettimada <vich@nordicsemi.no>
Increase the ISO Tx Buffers to avoid throttling of ISO data transmission when using 2 Broadcast ISO streams. Signed-off-by: Vinayak Kariappa Chettimada <vich@nordicsemi.no>
cvinayak
force-pushed
the
github_iso_broadcast_fix
branch
from
9eabe4f to
494be1b
Compare
Fix the iso_broadcast and iso_receive sample to wait on semaphore for all channel establishment and all channel terminate callbacks to be invoked. Signed-off-by: Vinayak Kariappa Chettimada <vich@nordicsemi.no>
cvinayak
force-pushed
the
github_iso_broadcast_fix
branch
from
494be1b to
d987491
Compare
cvinayak
requested review from
Vudentz,
alwa-nordic,
carlescufi,
jhedberg,
kruithofa,
sjanc and
thoh-ot
as code owners
zephyrbot
requested review from
asbjornsabo,
erbr-ot,
hermabe,
jori-nordic and
mtpr-ot
kruithofa
approved these changes
Sep 14, 2022
carlescufi
approved these changes
Sep 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix a leak in generation of Number of Completed Packets when
more than one handle has acknowledgements to be processed.
The loop exited for the current handle by dequeueing the
node tx element of the next handle leading to lost Number of
Completed Packets.
Restrict the calculated possible Pre-Transmission subevents
count to a maximum of 1 so that the full ISO interval is
not fully occupied by the BIG event.
Fix ISO broadcast implementation to flush stale ISO data for
all BIS streams and like wise generate acknowledgements for
all BIS streams that had its ISO data transmitted at its
reference anchor points.
Fix missing implementation to correctly to use data channel
index for subevents when previous subevent of previous BIS
stream where skipped.
Initialize the invalid ISO data packet generated by LLL.
Increase the ISO Tx Buffers to avoid throttling of ISO data
transmission when using 2 Broadcast ISO streams.
Fixes #50061.
Signed-off-by: Vinayak Kariappa Chettimada vich@nordicsemi.no