modem: cmux: Fix coverity issues #65431
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Possible NULL pointer dereferences where discovered by static code analysis, they are addressed in this commit. Signed-off-by: Bjarki Arge Andreasen <bjarki@arge-andreasen.me>
bjarki-andreasen
added
the
Trivial
kartben
approved these changes
Nov 18, 2023
fabiobaltieri
approved these changes
Nov 19, 2023
Member
|
@bjarki-trackunit there are three bugs linked to this PR, but I'm not sure why they didn't automatically close when the PR was merged. Will you please review/close them if appropriate? |
Contributor
Author
|
@MaureenHelm I think they are "false positives", I tried to address them in a way that coverity check would accept, but it just spawned new issues with dead code #66841 instead... and reopened these... working on fixing it :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possible NULL pointer dereferences where discovered by static code analysis, they are addressed in this commit.
Fixes #65367
Fixes #65363
Fixes #65362