tests: Bluetooth: Mesh: move semaphores out bsim initializations #73464
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is not correctly to call Zephyr API from bsim HW thread. Commit moves friendship test suite semaphores initialization into test bodies. Signed-off-by: Aleksandr Khromykh <aleksandr.khromykh@nordicsemi.no>
zephyrbot
requested review from
Andrewpini,
HaavardRei,
LingaoM,
PavelVPV,
akredalen,
jhedberg and
omkar3141
Contributor
Author
|
It is not correctly to call Zephyr API from bsim HW models thread initialization functionality |
Andrewpini
approved these changes
May 29, 2024
Contributor
|
Where is the semaphore initialization here? |
Contributor
Author
in test bodies in |
omkar3141
approved these changes
May 30, 2024
Contributor
Author
|
Hi @PavelVPV, this requires your attention. |
PavelVPV
approved these changes
Jun 3, 2024
kartben
added a commit
to kartben/zephyr
that referenced
this pull request
Dec 4, 2025
Last activity: 18 months ago (pr)
Recent activities:
- pr: Bluetooth: Mesh: Fix PB GATT adv name
zephyrproject-rtos#73526
(2024-05-30T13:56:48Z)
- commit: Commit to zephyrproject-rtos/zephyr
https://github.com/zephyrproject-rtos/zephyr (2024-05-30T07:00:00Z)
- review: Review on 'tests: Bluetooth: Mesh: move semaphores out bsim
initializations'
zephyrproject-rtos#73464
(2024-05-29T12:59:46Z)
Signed-off-by: Benjamin Cabé <benjamin@zephyrproject.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is not correctly to call Zephyr API from bsim
HW models thread.
Commit moves friendship test suite semaphores
initialization into test bodies.