Skip to content

tests: spi_loopback: kinetis dspi fix #77013

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 19, 2024
Merged

tests: spi_loopback: kinetis dspi fix #77013

merged 1 commit into from
Sep 19, 2024

Conversation

@hakehuang
Copy link
Contributor

@hakehuang hakehuang commented Aug 13, 2024 •
edited
Loading

  1. kenistis dspi does support rx and tx with different size, so skip the tx_bigger test.
  2. dspi dma need internal alignment and 8192 bytes are too many for k64, so reduce to 1440 bytes

Fixes: #77010

@zephyrbot zephyrbot added the area: SPI SPI bus label Aug 13, 2024
@zephyrbot zephyrbot requested review from tbursztyka and teburd August 14, 2024 09:53
@hakehuang hakehuang added the Hotfix Fix for issues blocking development, i.e. upstream CI issues, tests failing in upstream CI , etc. label Aug 14, 2024
@nashif
Copy link
Member

nashif commented Aug 14, 2024

that is not a hotfix, please refer to the hotfix description

@nashif nashif removed the Hotfix Fix for issues blocking development, i.e. upstream CI issues, tests failing in upstream CI , etc. label Aug 14, 2024
@hakehuang
Copy link
Contributor Author

hakehuang commented Aug 20, 2024

@teburd , @tbursztyka can you help to review, thanks

tbursztyka
tbursztyka reviewed Aug 20, 2024
View reviewed changes
tests/drivers/spi/spi_loopback/src/spi.c Outdated
Copy link
Contributor

@tbursztyka tbursztyka Aug 20, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1440 or 2440 (see your commit message) ?

Copy link
Contributor Author

@hakehuang hakehuang Aug 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1440 typo

Copy link
Contributor

@tbursztyka tbursztyka Aug 21, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok. Btw in your commit message: s/fixing:/Fixes:

@hakehuang
tests: spi_loopback: kinetis dspi fix
b1f1f74 
1. kenistis dspi does support rx and tx with different size,
so skip the tx_bigger test.
2. dspi dma need internal alignment and 8192 bytes are too
many for k64, so reduce to 1440 bytes

fixing: zephyrproject-rtos#77010

Signed-off-by: Hake Huang <hake.huang@oss.nxp.com>
@hakehuang hakehuang force-pushed the nxp_spi_loopback_fix branch from 4387c57 to b1f1f74 Compare August 21, 2024 03:40
@hakehuang hakehuang requested a review from tbursztyka August 22, 2024 08:40
@hakehuang
Copy link
Contributor Author

hakehuang commented Sep 10, 2024 •
edited
Loading

@teburd please help to review, thanks.

@hakehuang
Copy link
Contributor Author

hakehuang commented Sep 19, 2024

@teburd please help to take a look. Thanks

@nashif nashif merged commit b4ff177 into zephyrproject-rtos:main Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@teburd teburd teburd approved these changes

@tbursztyka tbursztyka tbursztyka approved these changes

Assignees

@tbursztyka tbursztyka

Labels

area: SPI SPI bus

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

tests: spi_loopback: kinetis: dma: some test is not supported well in kinetis dspi

5 participants

@hakehuang @nashif @teburd @tbursztyka @zephyrbot