samples: button: add comment for input subsys
#79080
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arifbalik
changed the title
input subsys
Contributor
|
Why is the note in the README not enough? |
Member
Author
|
Apparently people still miss the README file and think there is no debounced driver. edit: My pr commit body was too long, so i pushed with a smaller one |
arifbalik
force-pushed
the
basic_button_example_doc_update
branch
from
c24ae0c to
d779c80
Compare
kartben
approved these changes
Oct 25, 2024
Member
Author
|
@fabiobaltieri the file has the copyright line but the CI somehow fails with this output |
We wanted to redirect users who wants a debounced driver zephyrproject-rtos#78813 Signed-off-by: Arif Balik <arif.balik@enda.com>
fabiobaltieri
force-pushed
the
basic_button_example_doc_update
branch
from
d779c80 to
517f09a
Compare
Member
|
@arifbalik yeah kicked a retry but it failed still, the file is gone from main but I think that that specific check does not rebase, I rebased and pushed it for you, should work now. No idea how it got there in the first place and why it's failing here though but let's pretend it was transient. |
Member
Author
|
thanks, this will be a fun pr to merge on my bday today 🎉 😄 |
dkalowsk
approved these changes
Oct 26, 2024
Contributor
|
happy birthday... |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We wanted to redirect users who wants a debounced driver, as discussed here
Fixes #78813