drivers: sensor: adxl362: Updated ADXL362 driver with RTIO stream functionality #79712
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
requested review from
MaureenHelm,
avisconti,
galak,
jeppenodgaard,
microbuilder,
ozersa,
teburd,
tristan-google,
ttmut,
ubieda and
yperess
vladislav-pejic
force-pushed
the
adi_adxl362_rtio_stream
branch
6 times, most recently
from
2d903df to
aa22363
Compare
Updated ADXL362 driver with RTIO stream functionality. RTIO stream is using both FIFO threshold and FIFO full triggers. Together with RTIO stream, RTIO async read is also implemented. Signed-off-by: Vladislav Pejic <vladislav.pejic@orioninc.com>
vladislav-pejic
force-pushed
the
adi_adxl362_rtio_stream
branch
from
aa22363 to
0d8e361
Compare
MaureenHelm
approved these changes
Oct 18, 2024
This was referenced Oct 18, 2024
teburd
approved these changes
Oct 22, 2024
Contributor
teburd
left a comment
teburd
left a comment
There was a problem hiding this comment.
Looks quite good to me, there's some minor things here and there that might be worth cleaning up, the 6 vs 8 byte stride in the fifo data could be #define'ed out perhaps rather than comments inline. The conversion from the sensors fifo format I do think warrants a second look or at least a comment as to why the math used here is needed.
|
|
||
| int64_t micro_ms2 = data_in * SENSOR_G / range_to_scale[range]; | ||
|
|
||
| *out = CLAMP((micro_ms2 + (micro_ms2 % 1000000)), INT32_MIN, INT32_MAX); |
Contributor
There was a problem hiding this comment.
the modulo and division above are going to be pretty costly I'd think? I again wonder if this can't be a simple scale multiplier to convert from what is likely already a fixed point adc reading to another scale and numerical container size
See #76968
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated ADXL362 driver with RTIO stream functionality. RTIO stream is using both FIFO threshold and FIFO full triggers. Together with RTIO stream, RTIO async read is also implemented.
Signed-off-by: Vladislav Pejic vladislav.pejic@orioninc.com