Skip to content

Conversation

@carlescufi
Copy link
Member

See commit messages.

@carlescufi carlescufi requested a review from anangl as a code owner October 16, 2024 20:09
@carlescufi carlescufi requested review from anangl, gmarull, jaz1-nordic, masz-nordic and nordicjm and removed request for anangl and nordicjm October 16, 2024 20:10
@carlescufi carlescufi added the Trivial Changes that can be reviewed by anyone, i.e. doc changes, minor build system tweaks, etc. label Oct 16, 2024
@kartben
Copy link
Contributor

kartben commented Oct 16, 2024

This can't reasonably be considered a "trivial"

@carlescufi carlescufi removed the Trivial Changes that can be reviewed by anyone, i.e. doc changes, minor build system tweaks, etc. label Oct 16, 2024
@carlescufi
Copy link
Member Author

This can't reasonably be considered a "trivial"

Fair enough, removed. I was "only" removing, but looking at the diff this got a bit out of hand :D

@carlescufi carlescufi force-pushed the remove-54l15-pdk branch 2 times, most recently from 34e8081 to 70dab1b Compare October 16, 2024 20:34
@carlescufi
Copy link
Member Author

carlescufi commented Oct 16, 2024

So it's impossible to make both the clang-format and checkpatch checks happy @pdgendt. If I make it so that the line it complains about is <100 columns, clang-format fails. Otherwise, checkpatch fails.

My mistake.

nordicjm
nordicjm previously approved these changes Oct 17, 2024
@carlescufi carlescufi requested a review from anangl October 17, 2024 13:43
@carlescufi carlescufi force-pushed the remove-54l15-pdk branch 2 times, most recently from 062c7f2 to 618dbee Compare October 18, 2024 09:28
anangl
anangl previously approved these changes Oct 18, 2024
kartben
kartben previously approved these changes Oct 18, 2024
nika-nordic
nika-nordic previously approved these changes Oct 18, 2024
A bunch of copy-paste mistakes when adding the nRF54L15 DK added stale
references to the Preview DK (PDK).

Signed-off-by: Carles Cufi <carles.cufi@nordicsemi.no>
The nRF54L15 Development Kit is now available, so remove the Preview
Development Kit (PDK).

Signed-off-by: Carles Cufi <carles.cufi@nordicsemi.no>
The production version of the nRF54L15 SoC is now available, so remove
the initial Engineering A (EngA) preview version.

Signed-off-by: Carles Cufi <carles.cufi@nordicsemi.no>
@carlescufi
Copy link
Member Author

@kartben @nika-nordic @anangl had to rebase to resolve conflicts

@dleach02 dleach02 merged commit 51c1e45 into zephyrproject-rtos:main Oct 21, 2024
25 checks passed
@Laczen Laczen removed their request for review October 24, 2024 03:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants