-
Notifications
You must be signed in to change notification settings - Fork 8.3k
doc: fix body length in SMP UART transport #80611
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Hello @smnmsr, and thank you very much for your first pull request to the Zephyr project! |
|
@smnmsr Fix commit message to make compliance happy. |
|
@smnmsr please fix compliance issue |
|
@smnmsr can you help fix the CI compliance check failures. |
In the description of the partial-final frame of the SMP UART transport specification was a typo in the maximum allowed raw body size. The size must not be larger than MTU - 5 because there are 5 bytes occupied by total length (2), frame termination (1) and crc (2). Signed-off-by: Simon Moser <simon.github@mailbox.org>
|
@smnmsr for the record: `git commit --amend --author="First Last your@email.com" :) @mmahadevan108 should be good to go now! |
|
Hi @smnmsr! To celebrate this milestone and showcase your contribution, we'd love to award you the Zephyr Technical Contributor badge. If you're interested, please claim your badge by filling out this form: Claim Your Zephyr Badge. Thank you for your valuable input, and we look forward to seeing more of your contributions in the future! 🪁 |
In the description of the partial-final frame of the SMP UART transport specification was a typo in the maximum allowed raw body size. The size must not be larger than MTU-5 because there are 5 bytes occupied by total length (2), frame termination (1) and crc (2).