Skip to content

Conversation

@smnmsr
Copy link
Contributor

@smnmsr smnmsr commented Oct 30, 2024

In the description of the partial-final frame of the SMP UART transport specification was a typo in the maximum allowed raw body size. The size must not be larger than MTU-5 because there are 5 bytes occupied by total length (2), frame termination (1) and crc (2).

@zephyrbot zephyrbot added area: mcumgr size: XS A PR changing only a single line of code labels Oct 30, 2024
@github-actions
Copy link

Hello @smnmsr, and thank you very much for your first pull request to the Zephyr project!
Our Continuous Integration pipeline will execute a series of checks on your Pull Request commit messages and code, and you are expected to address any failures by updating the PR. Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request. If you haven't already, please make sure to review the project's Contributor Expectations and update (by amending and force-pushing the commits) your pull request if necessary.
If you are stuck or need help please join us on Discord and ask your question there. Additionally, you can escalate the review when applicable. 😊

@nordicjm nordicjm added the Trivial Changes that can be reviewed by anyone, i.e. doc changes, minor build system tweaks, etc. label Oct 30, 2024
@nordicjm nordicjm added this to the v4.0.0 milestone Oct 30, 2024
@nordicjm nordicjm added the backport v3.7-branch Request backport to the v3.7-branch label Oct 30, 2024
@de-nordic
Copy link
Contributor

@smnmsr Fix commit message to make compliance happy.

@nordicjm
Copy link
Contributor

nordicjm commented Nov 7, 2024

@smnmsr please fix compliance issue

@mmahadevan108
Copy link
Contributor

@smnmsr can you help fix the CI compliance check failures.

In the description of the partial-final frame of the SMP UART transport
specification was a typo in the maximum allowed raw body size. The size
must not be larger than MTU - 5 because there are 5 bytes occupied by
total length (2), frame termination (1) and crc (2).

Signed-off-by: Simon Moser <simon.github@mailbox.org>
@kartben
Copy link
Contributor

kartben commented Nov 8, 2024

@smnmsr for the record: `git commit --amend --author="First Last your@email.com" :)

@mmahadevan108 should be good to go now!

@mmahadevan108 mmahadevan108 merged commit a77d499 into zephyrproject-rtos:main Nov 8, 2024
16 checks passed
@github-actions
Copy link

github-actions bot commented Nov 8, 2024

Hi @smnmsr!
Congratulations on getting your very first Zephyr pull request merged 🎉🥳. This is a fantastic achievement, and we're thrilled to have you as part of our community!

To celebrate this milestone and showcase your contribution, we'd love to award you the Zephyr Technical Contributor badge. If you're interested, please claim your badge by filling out this form: Claim Your Zephyr Badge.

Thank you for your valuable input, and we look forward to seeing more of your contributions in the future! 🪁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: mcumgr backport v3.7-branch Request backport to the v3.7-branch size: XS A PR changing only a single line of code Trivial Changes that can be reviewed by anyone, i.e. doc changes, minor build system tweaks, etc.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants