Skip to content

Conversation

@nxp-shelley
Copy link
Contributor

fixes: #80721
Updated mpu region address to secure address.

@github-actions
Copy link

github-actions bot commented Nov 1, 2024

Hello @nxp-shelley, and thank you very much for your first pull request to the Zephyr project!
Our Continuous Integration pipeline will execute a series of checks on your Pull Request commit messages and code, and you are expected to address any failures by updating the PR. Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request. If you haven't already, please make sure to review the project's Contributor Expectations and update (by amending and force-pushing the commits) your pull request if necessary.
If you are stuck or need help please join us on Discord and ask your question there. Additionally, you can escalate the review when applicable. 😊

@DerekSnell
Copy link
Contributor

DerekSnell commented Nov 1, 2024

@hakehuang , can you run our tests on this board, and ensure they all pass with this PR?

@lucien-nxp , can you please review this PR?

Copy link
Contributor

@DerekSnell DerekSnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @nxp-shelley for resolving this.
But can you review these comments about the FlexSPI region sizes?

I did replicate the issue, and see this PR resolves it. When building the ADC test below from the main branch, nothing prints out the console. With this patch, the test passes and can be reflashed.

west build -b mimxrt1180_evk//cm33 tests/drivers/adc/adc_api/ --pristine

@hakehuang
Copy link
Contributor

hakehuang commented Nov 1, 2024

@hakehuang , can you run our tests on this board, and ensure they all pass with this PR?

@DerekSnell it works.

@dleach02 dleach02 added this to the v4.0.0 milestone Nov 1, 2024
fixes: zephyrproject-rtos#80721
Updated mpu region address to secure address.

Signed-off-by: Xiaoli Ji <xiaoli.ji@nxp.com>
@hakehuang hakehuang requested a review from DerekSnell November 6, 2024 15:04
@mmahadevan108 mmahadevan108 added the bug The issue is a bug, or the PR is fixing a bug label Nov 6, 2024
Copy link
Contributor

@DerekSnell DerekSnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, @nxp-shelley . Thank you for this fix!

@mmahadevan108 mmahadevan108 merged commit e20c095 into zephyrproject-rtos:main Nov 6, 2024
25 checks passed
@mmahadevan108 mmahadevan108 deleted the fix/rt1180_mpu branch November 6, 2024 20:43
@github-actions
Copy link

github-actions bot commented Nov 6, 2024

Hi @nxp-shelley!
Congratulations on getting your very first Zephyr pull request merged 🎉🥳. This is a fantastic achievement, and we're thrilled to have you as part of our community!

To celebrate this milestone and showcase your contribution, we'd love to award you the Zephyr Technical Contributor badge. If you're interested, please claim your badge by filling out this form: Claim Your Zephyr Badge.

Thank you for your valuable input, and we look forward to seeing more of your contributions in the future! 🪁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug The issue is a bug, or the PR is fixing a bug platform: NXP NXP

Projects

None yet

Development

Successfully merging this pull request may close these issues.

tests: mimxrt1180_evk: mpu fault cause CI broken

7 participants