Bluetooth: BAP: Add a set of suggested intervals to use with BAP #81093

Thalley · 2024-11-07T18:05:22Z

Add a selection of interval values that are suitable for BAP,
which will allow better coexistence between ISO and ACL,
for both broadcast and unicast.

Samples and tests have been updated to use these new values.

The shell has also been updated to use the LE Audio (BAP) values
if audio is enabled, and the audio.conf file has disabled automatic
updating of the connection parameters as the peripheral, as we rarely
(if ever) want to do that.

include/zephyr/bluetooth/audio/bap.h

Thalley · 2025-02-06T07:34:33Z

CI failure depends on #84297

cvinayak · 2025-02-06T14:35:54Z

CI failure depends on #84297

This PR is no longer blocked by Controller bugs, if any?

Thalley · 2025-02-06T14:39:05Z

CI failure depends on #84297

This PR is no longer blocked by Controller bugs, if any?

Nope :) #83539 is still though, and the combination of these 2 PRs might bring out new bugs

Will re-review after #84297 is merged.

samples/bluetooth/bap_unicast_server/prj.conf

Thalley · 2025-02-24T20:33:10Z

@rugeGerritsen please re-review or dismiss you change request :)

rugeGerritsen

Commit message needs to be updated as we are no longer disabling tests

rugeGerritsen · 2025-02-25T07:26:18Z

include/zephyr/bluetooth/audio/bap.h

+ *
+ * Defined by Table 8.1 in BAP 1.0.2
+ */
+#define BT_BAP_ADV_PARAM_CONN_QUICK                                                                \


In this file we now use QUICK/SHORT/FAST and REDUCED/SLOW. The existing advertising macros use FAST and SLOW only, so maybe we should stick to that?

The existing advertising macros use FAST and SLOW only, so maybe we should stick to that?

The BT Core spec uses "FAST" and "SLOW" when defining the values

The BAP spec does not defines values for advertising, but the BAP macros for advertising in this PR uses SLOW and FAST.

The Core spec does not defined slow/fast values for connection parameters, and only has

Not sure if it makes sense to define SLOW and FAST for connection parameters, since those are not defined by Zephyr or Core Spec either.

The BAP spec uses the following terminology

I'm OK to modify it to always be fast and slow for consistency if you think that makes more sense

I do not have a strong opinion on this. But I believe it may make sense to align terminology with existing macros

Maybe @cvinayak or @larsgk have some opinion on this?

Typically, I always open up a Spec PDF and search for terms like "quick" or "reduced", in this case the BAP spec. Hence, I will keep the QUICK and REDUCED in this context to be able to quickly refer to spec definitions.

If the other new defined with FAST, SLOW and RELAXED too have references to in the BAP spec, I will use it so.

@rugeGerritsen Please re-review :)

cvinayak

I thought this PR passed CI before rebase, the bsim air trace needs to be analysed to figure cause.

cvinayak · 2025-03-10T03:55:05Z

include/zephyr/bluetooth/audio/bap.h

+ *
+ * Defined by Table 8.1 in BAP 1.0.2
+ */
+#define BT_BAP_ADV_PARAM_CONN_QUICK                                                                \


Typically, I always open up a Spec PDF and search for terms like "quick" or "reduced", in this case the BAP spec. Hence, I will keep the QUICK and REDUCED in this context to be able to quickly refer to spec definitions.

If the other new defined with FAST, SLOW and RELAXED too have references to in the BAP spec, I will use it so.

cvinayak · 2025-03-10T04:51:58Z

Workaround for failing test due to overlapping Peripheral ACL in the broadcast sink device:

diff --git a/tests/bsim/bluetooth/audio/test_scripts/bap_broadcast_audio_assistant.sh b/tests/bsim/bluetooth/audio/test_scripts/bap_broadcast_audio_assistant.sh
index 4b2bc395429..92a67968e64 100755
--- a/tests/bsim/bluetooth/audio/test_scripts/bap_broadcast_audio_assistant.sh
+++ b/tests/bsim/bluetooth/audio/test_scripts/bap_broadcast_audio_assistant.sh
@@ -25,7 +25,8 @@ Execute ./bs_${BOARD_TS}_tests_bsim_bluetooth_audio_prj_conf \
 Execute ./bs_${BOARD_TS}_tests_bsim_bluetooth_audio_prj_conf \
   -v=${VERBOSITY_LEVEL} -s=${SIMULATION_ID} -d=2 \
   -testid=broadcast_source -RealEncryption=1 -rs=69 -D=3 \
-  -start_offset=5e3 -argstest subgroup_cnt 1 streams_per_subgroup_cnt 2
+  -start_offset=2e3 \
+  -argstest subgroup_cnt 1 streams_per_subgroup_cnt 2 \
 
 # Simulation time should be larger than the WAIT_TIME in common.h
 Execute ./bs_2G4_phy_v1 -v=${VERBOSITY_LEVEL} -s=${SIMULATION_ID} -D=3 -sim_length=60e6 $@

To correctly handle drifting ACL into BIG events, need the scheduling to permit selective BIS subevent reception. Some experiments in this draft #75760 (still a WIP though as support for interleaved too needs consideration, which is also open #67231).

Add a selection of interval values that are suitable for BAP, which will allow better coexistence between ISO and ACL, for both broadcast and unicast. Some of these are defined by the BAP spec, and some are defined by Zephyr, since they do have a suggested value from BAP. Samples and tests have been updated to use these new values. Peripheral samples have also been updated with CONFIG_BT_GAP_AUTO_UPDATE_CONN_PARAMS so that the connection parameters from the centrals aren't updated to something else shortly after. The shell has also been updated to use the LE Audio (BAP) values if audio is enabled, and the audio.conf file has disabled automatic updating of the connection parameters as the peripheral, as we rarely (if ever) want to do that. Due to the connection interval change, CI hit an issue with test_bass_broadcast_code in test_main_client_sync, where the reading of the long receive state did not finish before we attempted to do another procedure, so the function was updated to have a retry. Signed-off-by: Emil Gydesen <emil.gydesen@nordicsemi.no>

Thalley changed the title ~~Audio interval macros~~ Bluetooth: BAP: Add a set of suggested intervals to use with BAP Nov 7, 2024

Thalley mentioned this pull request Nov 7, 2024

Bluetooth: Host: Add conversion macros from ms to various units #81068

Merged

Thalley added this to the v4.1.0 milestone Nov 7, 2024

Thalley force-pushed the audio_interval_macros branch 3 times, most recently from ad61f81 to b94bd7b Compare November 7, 2024 20:37

Thalley commented Nov 9, 2024

View reviewed changes

include/zephyr/bluetooth/audio/bap.h Outdated Show resolved Hide resolved

Thalley commented Nov 9, 2024

View reviewed changes

include/zephyr/bluetooth/audio/bap.h Outdated Show resolved Hide resolved

Thalley force-pushed the audio_interval_macros branch from b94bd7b to f4f3960 Compare November 9, 2024 00:28

Thalley force-pushed the audio_interval_macros branch from f4f3960 to 60198f5 Compare November 18, 2024 10:14

Thalley marked this pull request as ready for review November 18, 2024 16:05

zephyrbot added area: Samples Samples area: Bluetooth area: Bluetooth Host Bluetooth Host (excluding BR/EDR) area: Bluetooth Audio labels Nov 18, 2024

zephyrbot requested review from Casper-Bonde-Bose, MariuszSkamra, asbjornsabo, babrsn, fredrikdanebjer, jhedberg, jthm-ot, kartben, kruithofa, larsgk, nashif, niym-ot, pin-zephyr and sjanc November 18, 2024 16:06

zephyrbot assigned kartben Nov 18, 2024

Thalley force-pushed the audio_interval_macros branch 2 times, most recently from f7716ab to 3c06ff4 Compare January 24, 2025 13:32

Thalley force-pushed the audio_interval_macros branch from 3c06ff4 to ab7faed Compare February 6, 2025 06:15

cvinayak previously approved these changes Feb 7, 2025

View reviewed changes

samples/bluetooth/bap_unicast_server/prj.conf Show resolved Hide resolved

larsgk previously approved these changes Feb 15, 2025

View reviewed changes

Thalley modified the milestones: v4.1.0, v4.2.0 Feb 17, 2025

Thalley force-pushed the audio_interval_macros branch from ab7faed to 44004d5 Compare February 17, 2025 10:30

rugeGerritsen requested changes Feb 25, 2025

View reviewed changes

Thalley requested a review from rugeGerritsen February 25, 2025 07:50

Thalley dismissed stale reviews from larsgk and cvinayak via 364e18e March 9, 2025 21:38

Thalley force-pushed the audio_interval_macros branch from 44004d5 to 364e18e Compare March 9, 2025 21:38

zephyrbot added the Release Notes To be mentioned in the release notes label Mar 9, 2025

cvinayak reviewed Mar 10, 2025

View reviewed changes

Thalley force-pushed the audio_interval_macros branch from 364e18e to 7d84741 Compare March 10, 2025 06:15

cvinayak approved these changes Mar 10, 2025

View reviewed changes

Thalley requested a review from larsgk March 10, 2025 09:49

rugeGerritsen approved these changes Mar 11, 2025

View reviewed changes

kartben merged commit 9d4cc4b into zephyrproject-rtos:main Mar 11, 2025
23 checks passed

github-project-automation bot moved this from In Review to Done in Bluetooth LE Audio Mar 11, 2025

Thalley deleted the audio_interval_macros branch March 11, 2025 08:21

cvinayak mentioned this pull request Mar 11, 2025

Bluetooth: Controller: ISO Sync Receiver with ticks_slot_window #75760

Draft

Bluetooth: BAP: Add a set of suggested intervals to use with BAP #81093

Bluetooth: BAP: Add a set of suggested intervals to use with BAP #81093

Uh oh!

Conversation

Thalley commented Nov 7, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Thalley commented Feb 6, 2025

Uh oh!

cvinayak commented Feb 6, 2025

Uh oh!

Thalley commented Feb 6, 2025

Uh oh!

Uh oh!

Thalley commented Feb 24, 2025

Uh oh!

rugeGerritsen left a comment

Choose a reason for hiding this comment

Uh oh!

rugeGerritsen Feb 25, 2025

Choose a reason for hiding this comment

Uh oh!

Thalley Feb 25, 2025

Choose a reason for hiding this comment

Uh oh!

rugeGerritsen Feb 25, 2025

Choose a reason for hiding this comment

Uh oh!

rugeGerritsen Feb 25, 2025

Choose a reason for hiding this comment

Uh oh!

cvinayak Mar 10, 2025

Choose a reason for hiding this comment

Uh oh!

Thalley Mar 11, 2025

Choose a reason for hiding this comment

Uh oh!

cvinayak left a comment

Choose a reason for hiding this comment

Uh oh!

cvinayak Mar 10, 2025

Choose a reason for hiding this comment

Uh oh!

cvinayak commented Mar 10, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

7 participants

Thalley commented Nov 7, 2024 •

edited

Loading

cvinayak commented Mar 10, 2025 •

edited

Loading