- 
                Notifications
    
You must be signed in to change notification settings  - Fork 8.2k
 
tests: boards: nrf: hwinfo: Add test for reset cause on nrf54* #83126
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tests: boards: nrf: hwinfo: Add test for reset cause on nrf54* #83126
Conversation
| 
           FYI: @nordic-piks , @kl-cruz.  | 
    
f9a9ae6    to
    505de46      
    Compare
  
    99cbcef    to
    38ef8e2      
    Compare
  
    | 
           Build failure on nrf54l15dk (undefined reference to `sys_reboot') will be analysed by driver developers.  | 
    
38ef8e2    to
    1ccf77c      
    Compare
  
    There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To be honest, I'm not in favor of this tests.
This test are very hw dependent. For example, I don't think that there is a guarantee that data is retained after a reset in noinit sections.
Second, you should make use of the testing framework for maintainability.
          
 Indeed, this test is "complicated". However, this is because there are resets in the middle of each test case: 
 
 Therefore, I put platform_allow in the testcase.yaml 
 I have to store somehow information about test suite state. Solution where test state is stored in variable at .noinit section was copied from following watchdog driver test: 
 ZTEST test framework doesn't support reset in the middle of test. After boot, it will always start with the first test case. @alexanderwachter : What about moving it to a different directory?  | 
    
1ccf77c    to
    272bd40      
    Compare
  
    5b750fe    to
    1daa2e2      
    Compare
  
    Add test that checks reset cause reported by HWINFO. Check that hwinfo_get_supported_reset_cause() returns expected value. Check that hwinfo_get_reset_cause() correctly detects: - RESET_PIN, - RESET_SOFTWARE, - RESET_WATCHDOG. Check that reset cause can be cleared with hwinfo_clear_reset_cause(). Signed-off-by: Sebastian Głąb <sebastian.glab@nordicsemi.no>
1daa2e2    to
    8461966      
    Compare
  
    | 
           I moved test to zephyr/tests/boards/nrf/hwinfo/reset_cause/  | 
    
Include tests: drivers: hwinfo: Add test for reset cause on nrf54h20 nrfconnect/sdk-zephyr#2401 zephyrproject-rtos/zephyr#83126 Signed-off-by: Sebastian Głąb <sebastian.glab@nordicsemi.no>
Include tests: drivers: hwinfo: Add test for reset cause on nrf54h20 nrfconnect/sdk-zephyr#2401 zephyrproject-rtos/zephyr#83126 Signed-off-by: Sebastian Głąb <sebastian.glab@nordicsemi.no>
Add test that checks reset cause reported by HWINFO.
Check that hwinfo_get_supported_reset_cause() returns expected value.
Check that hwinfo_get_reset_cause() correctly detects:
Check that reset cause can be cleared with hwinfo_clear_reset_cause().