arch: arm: cortex_m: Consolidate bss/noinit sections for kernel/user mode #83721
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…mode Userspace originally required bss to precede kobject_data, as kobject_data size was not known until the final linking stage (zephyrproject-rtos#21747). zephyrproject-rtos#33687 reserved space for kobject_data, allowing bss to now be after kobject_data. Placing bss/noinit at the end of the linker script reduces the size of a "zephyr.bin" file, as the NOLOAD sections can be excluded. It also keeps the code common between kernel/user mode Signed-off-by: Grant Ramsay <gramsay@enphaseenergy.com>
zephyrbot
requested review from
MaureenHelm,
bbolen,
carlocaione,
dcpleung,
galak,
ithinuel,
microbuilder,
nashif,
stephanosio and
wearyzen
|
Could you please have a look at this comment. I think we might have introduced an issue with __kernel_ram_start already in #74042 but I am not sure what the impact is since there is no test failure. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Userspace originally required bss to precede kobject_data, as kobject_data size was not known until the final linking stage (#21747).
#33687 reserved space for kobject_data, allowing bss to now be after kobject_data.
Placing bss/noinit at the end of the linker script reduces the size of a "zephyr.bin" file, as the NOLOAD sections can be excluded. It also keeps the code common between kernel/user mode
@tejlmand as discussed here: #74042 (comment)