drivers: spi: nrfx: Add explicit dependency to GPIO #85390
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
added
size: XS
kartben
previously approved these changes
Feb 13, 2025
Contributor
Author
|
@anangl , would you mind reviewing this PR? |
anangl
reviewed
Feb 21, 2025
drivers/spi/Kconfig.nrfx
Outdated
| default y | ||
| depends on SOC_FAMILY_NORDIC_NRF | ||
| depends on MULTITHREADING | ||
| depends on GPIO |
Member
There was a problem hiding this comment.
Now we will get:
- A CMake warning will be issued that the SPI driver is not compiled in.
- A linker error in
spi_nor.cfailing to reference a SPI driver.With this it becomes more obvious that SPI driver is enabled by default because of the external flash mounted on the DK.
I'm afraid it might still not be obvious enough. The linker error is quite cryptic, as it says about undefined reference to __device_dts_ord_*. How do you know that the device is SPI?
Hence, I think it should be select GPIO. Then, for CONFIG_GPIO=n, we'll get a Kconfig warning that GPIO got the value y, although it was supposed to be n. And in menuconfig, one can find out what exactly makes this option set to y.
This dependency was always there but not explicitly defined. By adding the explicit dependency it becomes more obvious what is wrong when SPI is enabled but GPIO disabled. This was found when building `samples/bluetooth/peripheral` for `nrf54l15dk/nrf54l15/cpuapp` with `CONFIG_GPIO=n`. Before we got: - A linker error in `spi_nrfx_common.c` failing to reference some nrfx_gpiote APIs. - A linker error in `spi_nrfx_spim.c` failing to reference the GPIO dts entry. Now we will get a warning of that GPIO is not enabled With this it becomes more obvious that SPI driver is enabled by default because of the external flash mounted on the DK. Signed-off-by: Rubin Gerritsen <rubin.gerritsen@nordicsemi.no>
rugeGerritsen
force-pushed
the
spi_nrfx_requires_gpio
branch
from
472d5b4 to
41882b7
Compare
Contributor
Author
|
@anangl , can you please have a look at this? |
kartben
approved these changes
Apr 4, 2025
anangl
approved these changes
Apr 4, 2025
Contributor
|
ping @tbursztyka |
tbursztyka
approved these changes
May 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This dependency was always there but not explicitly defined. By adding the explicit dependency it becomes more obvious what is wrong when SPI is enabled but GPIO disabled.
This was found when building
samples/bluetooth/peripheralfornrf54l15dk/nrf54l15/cpuappwithCONFIG_GPIO=n.Before we got:
spi_nrfx_common.cfailing to reference some nrfx_gpiote APIs.spi_nrfx_spim.cfailing to reference the GPIO dts entry.Now we will get:
spi_nor.cfailing to reference a SPI driver.With this it becomes more obvious that SPI driver is enabled by default because of the external flash mounted on the DK.