Skip to content

Conversation

@Kronosblaster
Copy link
Contributor

@Kronosblaster Kronosblaster commented Feb 18, 2025

Provided for a direct method to build for the TI SK-AM62 (sk_am62). It was tested to be functional on the AM62B-SKEVM-P1 rev A board. Simple testing can be done by building the hello world example with:
west build -p -b sk_am62/am6234/a53 samples/hello_world.

https://builds.zephyrproject.io/zephyr/pr/85907/docs/boards/ti/sk_am62/doc/index.html

@zephyrbot zephyrbot added the platform: TI K3 Texas Instruments Keystone 3 Processors label Feb 18, 2025
@github-actions
Copy link

Hello @Kronosblaster, and thank you very much for your first pull request to the Zephyr project!
Our Continuous Integration pipeline will execute a series of checks on your Pull Request commit messages and code, and you are expected to address any failures by updating the PR. Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request. If you haven't already, please make sure to review the project's Contributor Expectations and update (by amending and force-pushing the commits) your pull request if necessary.
If you are stuck or need help please join us on Discord and ask your question there. Additionally, you can escalate the review when applicable. 😊

@nordicjm
Copy link
Contributor

merge commits need removing

@Kronosblaster
Copy link
Contributor Author

merge commits need removing

done

@vaishnavachath
Copy link
Member

Please don't create fixup commits for addressing feedback, See https://docs.zephyrproject.org/latest/contribute/contributor_expectations.html#pr-requirements

@vaishnavachath
Copy link
Member

Follow commit message guidelines
https://docs.zephyrproject.org/latest/contribute/guidelines.html#commit-message-guidelines

Copy link
Contributor

@dnltz dnltz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor issues. Your history is still a little bit off. Just remove this "Fixed documentation errors" and squash those changes into one commit.

For example:

get reset --soft 35caaa199aba3b97614eb3161e23b354411d8af8
git commit --am

@Kronosblaster Kronosblaster force-pushed the main branch 3 times, most recently from ea78127 to c3db511 Compare February 20, 2025 06:48
@Kronosblaster Kronosblaster changed the title Added west build target for ARM Cortex A53 for the SK-Am62 EVM boards: skam62evm: Added west build target for ARM Cortex A53 for the SK-Am62 EVM Feb 20, 2025
@Kronosblaster Kronosblaster force-pushed the main branch 2 times, most recently from 602ffa1 to 81b8e36 Compare February 26, 2025 09:52
@Kronosblaster Kronosblaster changed the title boards: skam62evm: Added west build target for ARM Cortex A53 for the SK-Am62 EVM boards: ti: skam62evm: Added west build target for ARM Cortex A53 for the SK-Am62 EVM May 5, 2025
@dnltz
Copy link
Contributor

dnltz commented May 5, 2025

@Kronosblaster can you please rebase to main?

@dnltz dnltz requested review from dnltz and vaishnavachath May 5, 2025 13:43
@Kronosblaster Kronosblaster force-pushed the main branch 4 times, most recently from 4f39f75 to ec4bd49 Compare May 7, 2025 06:16
@Kronosblaster Kronosblaster force-pushed the main branch 5 times, most recently from f30d526 to acc9cb4 Compare May 8, 2025 04:32
Copy link
Contributor

@kartben kartben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MUCH better, thank you! Doc is almost good to go, just one last comment.

https://builds.zephyrproject.io/zephyr/pr/85907/docs/boards/ti/sk_am62/doc/index.html

@Kronosblaster Kronosblaster force-pushed the main branch 3 times, most recently from ce68ee6 to 18e83b5 Compare May 9, 2025 06:12
Added west build target for the AM62 SK EVM for the A53 cores.
Signed-off-by: Dave Joseph <d-joseph@ti.com>
@sonarqubecloud
Copy link

sonarqubecloud bot commented May 9, 2025

@kartben kartben requested a review from nordicjm May 9, 2025 08:24
@kartben kartben merged commit 62941d7 into zephyrproject-rtos:main May 13, 2025
24 checks passed
@github-actions
Copy link

Hi @Kronosblaster!
Congratulations on getting your very first Zephyr pull request merged 🎉🥳. This is a fantastic achievement, and we're thrilled to have you as part of our community!

To celebrate this milestone and showcase your contribution, we'd love to award you the Zephyr Technical Contributor badge. If you're interested, please claim your badge by filling out this form: Claim Your Zephyr Badge.

Thank you for your valuable input, and we look forward to seeing more of your contributions in the future! 🪁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: Documentation area: Kernel area: Testsuite Testsuite platform: TI K3 Texas Instruments Keystone 3 Processors

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants