dts: arm: nxp: add DAC support for RT11xx #86649
Conversation
zephyrbot
added
platform: NXP
zephyrbot
requested review from
DerekSnell,
EmilioCBen,
PetervdPerk-NXP,
Raymond0225,
bperseghetti,
butok,
dbaluta,
decsny,
dleach02,
manuargue,
martinjaeger and
mmahadevan108
decsny
left a comment
decsny
left a comment
There was a problem hiding this comment.
it is a good contribution, so don't let this change request phase you, but I have some blocking comment about this PR that should be addressed
| #include <zephyr/drivers/dac.h> | ||
| #include <zephyr/logging/log.h> | ||
|
|
||
| #include <fsl_dac12.h> |
There was a problem hiding this comment.
if this driver is depending on an MCUX SDK driver, then you need to also open a PR to the HAL_NXP zephyr module to edit the module cmake build it when appropriate. (am aware this is inconvenient, soon we are working to put this glue logic into the zephyr repo)
There was a problem hiding this comment.
It is depending on MCUX SDK driver and I already opened a PR on HAL_NXP module.
There was a problem hiding this comment.
You also need to update the zephyr/west.yaml manifest to link to your HAL_NXP PR. That will fix build issues with this PR, and keep the two repos synchronized. Setting the revision like below will link West to your HAL PR.
- name: hal_nxp
revision: pull/520/head
FPlohl
force-pushed
the
WIP/FPlohl/rt11xx_dac
branch
from
9f6cb00 to
ed1033c
Compare
|
i approve generally the PR but you need to update manifest for HAL change |
|
Hi @FPlohl , Thank you |
|
@DerekSnell I don't have any EVK boards, but I tested it with the DAC sample and the phyCORE-i.MX RT1170, for which a PR is currently in draft: #86756 . I added a commit to enable it for the MIMXRT1170-EVK. |
DerekSnell
left a comment
DerekSnell
left a comment
There was a problem hiding this comment.
Hi @FPlohl ,
Thank you for this contribution. I tested the DAC sample on the mimxrt1170_evk@A board, and the DAC outputs as it should. It works with both the cm7 and cm4 targets.
I see the dac_api test fails to build, and that appears to be causing CI failures for this PR. Since you will be updating, can you also update the MIMXRT1170-EVK board page and add a DAC row to the Supported Features table?
| #include <zephyr/drivers/dac.h> | ||
| #include <zephyr/logging/log.h> | ||
|
|
||
| #include <fsl_dac12.h> |
There was a problem hiding this comment.
You also need to update the zephyr/west.yaml manifest to link to your HAL_NXP PR. That will fix build issues with this PR, and keep the two repos synchronized. Setting the revision like below will link West to your HAL PR.
- name: hal_nxp
revision: pull/520/head
|
i removed the DNM since CI fails due to manifest not being updated anyways |
FPlohl
force-pushed
the
WIP/FPlohl/rt11xx_dac
branch
from
1561e35 to
e8c1ea9
Compare
|
The following west manifest projects have changed revision in this Pull Request:
✅ All manifest checks OK Note: This message is automatically posted and updated by the Manifest GitHub Action. |
zephyrbot
added
manifest
manifest-hal_nxp
DNM (manifest)
FPlohl
force-pushed
the
WIP/FPlohl/rt11xx_dac
branch
2 times, most recently
from
1f86310 to
f51b552
Compare
github-actions
bot
removed
manifest
manifest-hal_nxp
DNM (manifest)
Include DAC12 HAL driver in case CONFIG_DAC_MCUX_DAC12 is enabled. Signed-off-by: Florijan Plohl <florijan.plohl@norik.com>
Add driver shim for the NXP Digital-to-Analog (DAC12) module. Signed-off-by: Florijan Plohl <florijan.plohl@norik.com>
Add DAC support for RT11xx SOCs. Signed-off-by: Florijan Plohl <florijan.plohl@norik.com>
Enable DAC on MIMXRT1170-EVK for both Cortex M7 and M4. Signed-off-by: Florijan Plohl <florijan.plohl@norik.com>
FPlohl
force-pushed
the
WIP/FPlohl/rt11xx_dac
branch
from
f51b552 to
b7c3df7
Compare
8 participants
Add driver shim for the NXP Digital-to-Analog (DAC12) module and add DAC support for RT11xx SOCs.