drivers: usb: udc: Reduce unnecessary ep config lookups#87480
Merged
kartben merged 1 commit intozephyrproject-rtos:mainfrom Mar 31, 2025
Merged
drivers: usb: udc: Reduce unnecessary ep config lookups#87480kartben merged 1 commit intozephyrproject-rtos:mainfrom
kartben merged 1 commit intozephyrproject-rtos:mainfrom
Conversation
zephyrbot
added
platform: Ambiq
zephyrbot
requested review from
AlessandroLuo,
FRASTM,
GeorgeCGV,
MarkWangChinese,
RichardSWheatley,
aaronyegx,
djiatsaf-st,
erwango,
gautierg-st,
marwaiehm-st,
mathieuchopstm and
mmahadevan108
AlessandroLuo
previously approved these changes
Mar 24, 2025
zeonchew
approved these changes
Mar 24, 2025
Contributor
zeonchew
left a comment
zeonchew
left a comment
There was a problem hiding this comment.
Changes for udc_ambiq.c looks good to me.
MarkWangChinese
previously approved these changes
Mar 24, 2025
Member
|
@tmon-nordic please rebase |
UDC API passes struct udc_ep_config to all functions. Some UDC functions were using endpoint config structure while some were using device and endpoint number. This API inconsistency led to completely unnecessary endpoint structure lookups. Remove unnecessary lookups by using endpoint config structure pointer where it makes sense. Signed-off-by: Tomasz Moń <tomasz.mon@nordicsemi.no>
jfischer-no
approved these changes
Mar 31, 2025
carlescufi
approved these changes
Mar 31, 2025
AlessandroLuo
approved these changes
Mar 31, 2025
This was referenced Mar 31, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
UDC API passes struct udc_ep_config to all functions. Some UDC functions were using endpoint config structure while some were using device and endpoint number. This API inconsistency led to completely unnecessary endpoint structure lookups. Remove unnecessary lookups by using endpoint config structure pointer where it makes sense.