Skip to content

boards: lilygo: tdongle_s3: initial support #87493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
kartben merged 1 commit into from
Apr 4, 2025
Merged

boards: lilygo: tdongle_s3: initial support #87493

kartben merged 1 commit into from
Apr 4, 2025

Conversation

@stefan-golinschi
Copy link
Contributor

@stefan-golinschi stefan-golinschi commented Mar 21, 2025

This adds support for Lilygo T Dongle S3 Board.

nordicjm
nordicjm requested changes Mar 24, 2025
View reviewed changes
nordicjm
nordicjm reviewed Mar 28, 2025
View reviewed changes
Copy link
Contributor

@nordicjm nordicjm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

changes need squashing

@stefan-golinschi stefan-golinschi force-pushed the boards/tdongle_s3 branch 2 times, most recently from 0c3dc3d to 9e5efd4 Compare March 29, 2025 08:44
nordicjm
nordicjm previously approved these changes Apr 2, 2025
View reviewed changes
@stefan-golinschi
Copy link
Contributor Author

stefan-golinschi commented Apr 2, 2025

@kartben , could you please take a look on this PR?

kartben
kartben previously approved these changes Apr 2, 2025
View reviewed changes
Copy link
Contributor

@kartben kartben left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sorry for the late review - I think I can live with the typo I spotted, but if you have a chance maybe you can send a follow-up PR to fix it :)

@stefan-golinschi
Copy link
Contributor Author

stefan-golinschi commented Apr 2, 2025

sorry for the late review - I think I can live with the typo I spotted, but if you have a chance maybe you can send a follow-up PR to fix it :)

Should I do a forced push with this typo fix, or should I do it in a new PR?

@kartben
Copy link
Contributor

kartben commented Apr 2, 2025

Here is good I guess, both @nordicjm and I should be able to reapprove quickly :)

@stefan-golinschi stefan-golinschi dismissed stale reviews from kartben and nordicjm via ab9fbcf April 3, 2025 03:48
@kartben kartben requested a review from nordicjm April 3, 2025 04:23
nordicjm
nordicjm previously approved these changes Apr 3, 2025
View reviewed changes
@stefan-golinschi
boards: lilygo: tdongle_s3: initial support
05022ee 
This adds support for Lilygo T Dongle S3 Board.

Signed-off-by: Stefan Golinschi <stefan.golinschi@gmail.com>
@kartben kartben merged commit a40a4dc into zephyrproject-rtos:main Apr 4, 2025
19 checks passed
@github-actions
Copy link

github-actions bot commented Apr 4, 2025

Hi @stefan-golinschi!
Congratulations on getting your very first Zephyr pull request merged 🎉🥳. This is a fantastic achievement, and we're thrilled to have you as part of our community!

To celebrate this milestone and showcase your contribution, we'd love to award you the Zephyr Technical Contributor badge. If you're interested, please claim your badge by filling out this form: Claim Your Zephyr Badge.

Thank you for your valuable input, and we look forward to seeing more of your contributions in the future! 🪁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@kartben kartben kartben approved these changes

@nordicjm nordicjm nordicjm approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@stefan-golinschi @kartben @nordicjm