driver: i3c: cdns: minor fixes #87515
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dcpleung
previously approved these changes
Mar 22, 2025
It is most certainly 'okay' for a secondary controller to do a ENTDAA. Remove the 'block' that was preventing this. Signed-off-by: Ryan McClelland <ryanmcclelland@meta.com>
The datasheet erroneously suggested to add a + 1 to the abort len. This was suggested because if a controller gave a EoD, then it was afraid that the abort would take precedence over the EoD. This was not true. The EoD will always take precedence over a controller abort. Remove the + 1 as this can cause issues. For example, when talking to a part that will auto-increment a read address, having the +1 can unknownly move this address pointer further than anticipated. Signed-off-by: Ryan McClelland <ryanmcclelland@meta.com>
XenuIsWatching
force-pushed
the
i3c-cdns-minor-fixes
branch
from
e56e27a to
6cd2782
Compare
dcpleung
approved these changes
Mar 24, 2025
ttmut
reviewed
Apr 8, 2025
ttmut
approved these changes
Apr 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is most certainly 'okay' for a secondary controller to do a
ENTDAA. Remove the 'block' that was preventing this.
The datasheet erroneously suggested to add a + 1 to the abort len.
This was suggested because if a controller gave a EoD, then it was
afraid that the abort would take precedence over the EoD. This was
not true. The EoD will always take precedence over a controller
abort. Remove the + 1 as this can cause issues.
For example, when talking to a part that will auto-increment a read
address, having the +1 can unknownly move this address pointer further
than anticipated.