posix: net: Fix undefined behavior #87529
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephyrbot
added
size: XS
Contributor
Author
|
Seems like qemu_cortex_m0/nrf51822 doesn't have enough RAM for the integration tests |
Member
zephyr/tests/posix/net/testcase.yaml Line 9 in 961593d |
cfriedt
previously approved these changes
Mar 24, 2025
Contributor
Author
It's the tests in |
DanTGL
force-pushed
the
fix_undefined_behavior
branch
from
0882c4e to
89eb00e
Compare
The signedness of the variable caused undefined behavior because the sign bit is modified when it gets left-shifted. This fixes that by changing it to an unsigned variable. Signed-off-by: Daniel Hajjar <daniel.hajjar16@gmail.com>
DanTGL
force-pushed
the
fix_undefined_behavior
branch
from
89eb00e to
a075306
Compare
cfriedt
approved these changes
Apr 16, 2025
ycsin
approved these changes
Apr 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The signedness of the variable caused undefined behavior because the sign bit is modified when it gets left-shifted.
This fixes that by changing it to an unsigned variable.