Skip to content

Conversation

@LukaszMrugala
Copy link
Contributor

Blackbox tests now shall include smoke tests, that is: Twister calls in the environment.

@LukaszMrugala LukaszMrugala force-pushed the lmrugalx_move_86531_to_bbox branch 4 times, most recently from a1b9357 to 4ab2c51 Compare April 18, 2025 09:19
@LukaszMrugala LukaszMrugala marked this pull request as ready for review April 18, 2025 14:39
nashif
nashif previously approved these changes Apr 30, 2025
redzynix
redzynix previously approved these changes May 9, 2025
Blackbox tests now shall include smoke tests,
that is Twister calls in the environment.

Additionally, those smoke tests will run
on multiple platforms.

Signed-off-by: Lukasz Mrugala <lukaszx.mrugala@intel.com>
@LukaszMrugala LukaszMrugala force-pushed the lmrugalx_move_86531_to_bbox branch from 6b98f05 to 7b9c84a Compare May 12, 2025 14:21
@nashif nashif requested a review from arikgreen May 12, 2025 14:29
@sonarqubecloud
Copy link

@nashif nashif dismissed arikgreen’s stale review May 12, 2025 22:13

requested changes addressed

@nashif nashif requested review from PerMac, golowanow and hakehuang May 15, 2025 19:27
@kartben kartben merged commit d2ebe9c into zephyrproject-rtos:main May 16, 2025
34 checks passed
Copy link
Member

@golowanow golowanow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

would be nice to check twister run results are really what's expected.

toolchains: all

- name: Run Pytest For Twister Black Box Tests
if: ${{ startsWith(runner.os, 'ubuntu') }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

either ${{ startsWith(matrix.os, 'ubuntu') }} or ${{ runner.os }} == 'Linux' ?

EXTRA_TWISTER_FLAGS="-P native_sim --build-only"
elif [ "${{ runner.os }}" = "Windows" ]; then
EXTRA_TWISTER_FLAGS="-P native_sim --short-build-path -O /tmp/twister-out"
fi
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

elif
  EXTRA_TWISTER_FLAGS=""
fi

BASIC_FLAGS="--runtime-artifact-cleanup --force-color --inline-logs -T samples/hello_world -T samples/cpp/hello_world -v $EXTRA_TWISTER_FLAGS"
./scripts/twister --save-tests tests.file $BASIC_FLAGS
./scripts/twister --load-tests tests.file --emulation-only $BASIC_FLAGS
rm tests.file
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: test.file remains if the first twister call fails

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants