Bluetooth: Controller: Only select BT_TICKER_LAZY_GET for ZLL #89249
Conversation
github-actions
bot
added
size: XS
github-actions
bot
requested review from
Tronil,
carlescufi,
cvinayak,
erbr-ot,
thoh-ot and
wopu-ot
| bool "Periodic Advertising Sync Transfer sender" | ||
| depends on BT_CTLR_SYNC_TRANSFER_SENDER_SUPPORT | ||
| select BT_TICKER_LAZY_GET | ||
| select BT_TICKER_LAZY_GET if BT_LL_SW_SPLIT |
There was a problem hiding this comment.
Already covered here:
| select BT_TICKER_LAZY_GET if BT_LL_SW_SPLIT |
There was a problem hiding this comment.
Actually, that is insufficient since it only applies for Nordic controllers. The original change is correct
There was a problem hiding this comment.
But @Tronil , dont you have a custom choice on the same line as config BT_LLL_VENDOR_NORDIC/OPENISA where this select be present?
There was a problem hiding this comment.
We could have (we don't at the moment), but why not just have it in the one place instead of once per vendor?
There was a problem hiding this comment.
I will revert to the original solution then
There was a problem hiding this comment.
We could have (we don't at the moment), but why not just have it in the one place instead of once per vendor?
Just hopping to keep the specifics inside ll_sw_split Kconfig file. Not able to think of an alternative for now, approving the current change in this PR.
|
nitpick, prefer the commit title be prefixed as |
weeTike
force-pushed
the
fix_zll_only_kconfig_selection
branch
from
593716d to
35c428f
Compare
weeTike
changed the title
BT_TICKER_LAZY_GET is a ZLL only kconfig and should not be selected for other controllers. Signed-off-by: Timothy Keys <timothy.keys@nordicsemi.no>
weeTike
force-pushed
the
fix_zll_only_kconfig_selection
branch
from
35c428f to
d82bf44
Compare
| bool "Periodic Advertising Sync Transfer sender" | ||
| depends on BT_CTLR_SYNC_TRANSFER_SENDER_SUPPORT | ||
| select BT_TICKER_LAZY_GET | ||
| select BT_TICKER_LAZY_GET if BT_LL_SW_SPLIT |
There was a problem hiding this comment.
We could have (we don't at the moment), but why not just have it in the one place instead of once per vendor?
Just hopping to keep the specifics inside ll_sw_split Kconfig file. Not able to think of an alternative for now, approving the current change in this PR.
rugeGerritsen
left a comment
rugeGerritsen
left a comment
There was a problem hiding this comment.
Alternative approach is to add another declaration of BT_CTLR_SYNC_TRANSFER_SENDER inside the bt_ll_sw_split file
5 participants
BT_TICKER_LAZY_GET is a ZLL only kconfig and should not be selected for other controllers.