Skip to content

Conversation

@butok
Copy link
Contributor

@butok butok commented Apr 30, 2025

  • Delete nxp board-vendor references from non-NXP board .yaml files.
  • board.yml files already contain the correct board-vendor names.

@butok
Copy link
Contributor Author

butok commented Apr 30, 2025

The CI errors (not caused by this PR) have been reported.

Copy link

@jonas-rem jonas-rem left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since #89024 is merged, the board catalog is being generated by the vendor info in the board.yml files. For that reason I think it would be better to change the entries to the actual vendor instead of removing them.

Probably not all vendors would notice this change in order to update the correct vendor directly. That would make the vendor info unreliable again.

@butok
Copy link
Contributor Author

butok commented Apr 30, 2025

Since #89024 is merged, the board catalog is being generated by the vendor info in the board.yml files. For that reason I think it would be better to change the entries to the actual vendor instead of removing them.

Probably not all vendors would notice this change in order to update the correct vendor directly. That would make the vendor info unreliable again.

@jonas-rem

  • The board.yml already has the correct information.
  • No need to duplicate the board-vendor in other .yaml files, as it is already present in the main & root board.yml file.

@jonas-rem
Copy link

Since #89024 is merged, the board catalog is being generated by the vendor info in the board.yml files. For that reason I think it would be better to change the entries to the actual vendor instead of removing them.
Probably not all vendors would notice this change in order to update the correct vendor directly. That would make the vendor info unreliable again.

@jonas-rem

  • The board.yml already has the correct information.
  • No need to duplicate the board-vendor in other .yaml files, as it is already present in the main & root board.yml file.

Oh, yeah I confused those files.

@jonas-rem jonas-rem self-requested a review April 30, 2025 22:17
@butok
Copy link
Contributor Author

butok commented May 2, 2025

Thank you guys!

The CI fail is not caused by this PR:

- Delete nxp board-vendor references from non-NXP board .yaml files.
- board.yml files already contain the correct board-vendor names.

Signed-off-by: Andrej Butok <andrey.butok@nxp.com>
@butok butok force-pushed the del_nxp_vendor_from_non_nxp branch from f080a7f to 67db1c8 Compare May 13, 2025 07:25
@sonarqubecloud
Copy link

@dnltz dnltz assigned nordicjm and unassigned dnltz May 13, 2025
@dnltz
Copy link
Contributor

dnltz commented May 13, 2025

@nordicjm this PR was not listed in the Zephyr's merge list and I'm also not authorized to merge. Can you take over or assign someone who can?

@nordicjm nordicjm assigned kartben and unassigned nordicjm May 13, 2025
@kartben kartben merged commit 2a20787 into zephyrproject-rtos:main May 13, 2025
29 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants