soc: esp32: include ksched.h in esp32-mp.c #89417
Conversation
esp32-mp.c calls z_sched_ipi() so it needs to include ksched.h, as it is no longer included via kernel.h after removal of kernel/internal/smp.h. Signed-off-by: Daniel Leung <daniel.leung@intel.com>
github-actions
bot
added
platform: ESP32
github-actions
bot
requested review from
LucasTambor,
marekmatej,
raffarost,
sylvioalves,
uLipe and
wmrsouza
|
hmm, not liking that, we need a better way of doing this that does not involve including ksched.h which is internal to the kernel, but I can see this being included all over the place, SoCs however should not rely on and call private functons. oh well. |
|
I agree, it would be different if ipi function had a public function, it seems design violation the calling of z_ prefixed functions even though the SoC layer is something reserved for kernel driver foundation. But since the IPI is a primitive to support SMP, would cases like this sufficient to export a public version of the IPI function call? |
|
This is to fix build breakage. So maybe we can merge this and find a better solution later? |
uLipe
left a comment
uLipe
left a comment
There was a problem hiding this comment.
Giving my +1 to fix build, I think before proceed we can open an issue to avoid loosing the track.
7 participants
esp32-mp.c calls z_sched_ipi() so it needs to include ksched.h, as it is no longer included via kernel.h after removal of kernel/internal/smp.h.