Skip to content

Conversation

@squiniou
Copy link
Contributor

@squiniou squiniou commented May 4, 2025

Summary

  • Add display support for the st7789v LCD controller.
  • Automatically enable the LCD backlight at boot to use the display sample as is, because the LCD backlight is normally off.

Tests

Environment

Tested on an stm32h573i-dk board (mb1677-h573i-c02) with the display sample.

Commands

$ west build -p always -b stm32h573i_dk zephyr/samples/drivers/display
$ west flash --runner pyocd

Results

  • Backlight OK
  • Colors OK
  • Display OK

IMG20250504233911

References

Signed-off-by: Samuel Quiniou samuel.quiniou@rtone.fr

@github-actions github-actions bot added the platform: STM32 ST Micro STM32 label May 4, 2025
@github-actions
Copy link

github-actions bot commented May 4, 2025

Hello @squiniou, and thank you very much for your first pull request to the Zephyr project!
Our Continuous Integration pipeline will execute a series of checks on your Pull Request commit messages and code, and you are expected to address any failures by updating the PR. Please take a look at our commit message guidelines to find out how to format your commit messages, and at our contribution workflow to understand how to update your Pull Request. If you haven't already, please make sure to review the project's Contributor Expectations and update (by amending and force-pushing the commits) your pull request if necessary.
If you are stuck or need help please join us on Discord and ask your question there. Additionally, you can escalate the review when applicable. 😊

@squiniou
Copy link
Contributor Author

squiniou commented May 4, 2025

Fix check failed by removing trailing spaces.

@squiniou
Copy link
Contributor Author

squiniou commented May 4, 2025

Fix commit message: stm32h573i_dk instead of stm32h573i-dk

Copy link
Member

@erwango erwango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few tweaks otherwise looks good, thanks.

@squiniou
Copy link
Contributor Author

squiniou commented May 9, 2025

@erwango I took your review into account. Let me know if it looks good.

@squiniou squiniou requested a review from erwango May 12, 2025 10:29
erwango
erwango previously approved these changes May 12, 2025
Copy link
Member

@erwango erwango left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested functional. Thanks!

@erwango erwango requested a review from ajarmouni-st May 12, 2025 12:16
Copy link
Contributor

@etienne-lms etienne-lms left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One nitpicking comment. Otherwise LGTM.

Add display support for the st7789v LCD controller.
Automatically enable the LCD backlight at boot
to use the display sample as is,
because the LCD backlight is normally off.

Signed-off-by: Samuel Quiniou <samuel.quiniou@rtone.fr>
@sonarqubecloud
Copy link

@kartben kartben merged commit d0aa263 into zephyrproject-rtos:main May 13, 2025
21 checks passed
@github-actions
Copy link

Hi @squiniou!
Congratulations on getting your very first Zephyr pull request merged 🎉🥳. This is a fantastic achievement, and we're thrilled to have you as part of our community!

To celebrate this milestone and showcase your contribution, we'd love to award you the Zephyr Technical Contributor badge. If you're interested, please claim your badge by filling out this form: Claim Your Zephyr Badge.

Thank you for your valuable input, and we look forward to seeing more of your contributions in the future! 🪁

@squiniou squiniou deleted the st7789v_fmc branch May 14, 2025 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

platform: STM32 ST Micro STM32

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants