driver: ptp clock NXP ENET: invalid assertion #89450
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
platform: NXP Drivers
github-actions
bot
requested review from
Raymond0225,
dbaluta,
decsny,
dleach02,
manuargue,
mmahadevan108 and
tbursztyka
decsny
approved these changes
May 5, 2025
Assertion checked whether pointer is NULL. Assertion should check whether pointer is *not* NULL. Fixed by changing check in assertion. Signed-off-by: Frank Duerr <frank.duerr@ipvs.uni-stuttgart.de>
duerrfk
force-pushed
the
issue_ptpdrv_invalid_assertion
branch
from
aa15fec to
1932965
Compare
kartben
added
the
Trivial
kartben
approved these changes
May 15, 2025
dleach02
approved these changes
May 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #89449
The following assertion in the NXP PTP driver, function nxp_enet_ptp_clock_callback(), file zephyr/drivers/ptp_clock/ptp_clock_nxp_enet.c, is wrong:
The intention is to ensure that cb_data is not NULL, therefore, the check should be for cb_data != NULL: