Skip to content

Conversation

@soburi
Copy link
Member

@soburi soburi commented May 5, 2025

Add driver for iproc_rng200 entropy generator.
This device is used by rpi_5.

@soburi soburi changed the title Rpi5 rng drivers: entropy: add iproc_rng200 (rpi_5) random generator driver May 5, 2025
@soburi soburi force-pushed the rpi5_rng branch 2 times, most recently from dde64b5 to 277db57 Compare May 5, 2025 13:04
@soburi soburi added the platform: Raspberry Pi Raspberry Pi (Broadcom BCM27xx) label May 5, 2025
soburi added 2 commits May 5, 2025 22:12
Add sort directives to CMakeLists.txt and Kconfig

Signed-off-by: TOKITA Hiroshi <tokita.hiroshi@gmail.com>
Add driver for iproc_rng200 entropy generator.
This device is used by rpi_5.

Signed-off-by: TOKITA Hiroshi <tokita.hiroshi@gmail.com>
@soburi soburi marked this pull request as ready for review May 5, 2025 13:41
@github-actions github-actions bot added area: Crypto / RNG area: ARM64 ARM (64-bit) Architecture labels May 5, 2025
@soburi soburi requested a review from Copilot May 6, 2025 00:47
Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR adds a new driver for the Broadcom iProc RNG200 random generator, which is used by rpi_5. The changes include a new DTS binding description file and the complete implementation of the entropy driver in C.

Reviewed Changes

Copilot reviewed 2 out of 7 changed files in this pull request and generated 1 comment.

File Description
dts/bindings/rng/brcm,iproc-rng200.yaml Adds binding for the new iproc_rng200 random generator driver
drivers/entropy/entropy_iproc_rng200.c Implements the entropy driver functionality for iproc_rng200
Files not reviewed (5)
  • boards/raspberrypi/rpi_5/rpi_5.dts: Language not supported
  • drivers/entropy/CMakeLists.txt: Language not supported
  • drivers/entropy/Kconfig: Language not supported
  • drivers/entropy/Kconfig.iproc: Language not supported
  • dts/arm64/broadcom/bcm2712.dtsi: Language not supported

Copy link
Member

@ceolin ceolin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it looks good to me.

@soburi
Copy link
Member Author

soburi commented May 13, 2025

@Lahyllas @xingrz
Could you take a look please?

@soburi soburi requested a review from xingrz May 14, 2025 05:12
Copy link
Member

@xingrz xingrz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Lahyllas
Copy link
Contributor

I can't test this right now, but it looks pretty good to me.

@kartben kartben merged commit 431f202 into zephyrproject-rtos:main May 14, 2025
26 checks passed
@soburi soburi deleted the rpi5_rng branch May 14, 2025 07:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: ARM64 ARM (64-bit) Architecture area: Crypto / RNG platform: Raspberry Pi Raspberry Pi (Broadcom BCM27xx)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants