Skip to content

Conversation

@PavelVPV
Copy link
Contributor

@PavelVPV PavelVPV commented May 6, 2025

This PR reverts #75779 as SoftDevice Controller does not any longer send the disconnection event only after Host confirms all received ACL data throguh Host Number Of Completed Packets command.

PavelVPV added 2 commits May 12, 2025 09:55
This reverts commit 147ee3d.

Signed-off-by: Pavel Vasilyev <pavel.vasilyev@nordicsemi.no>
This reverts commit 32212bf.

Signed-off-by: Pavel Vasilyev <pavel.vasilyev@nordicsemi.no>
@PavelVPV PavelVPV force-pushed the revert_sending_hncp_in_advance branch from abbe045 to 97fb3ab Compare May 12, 2025 07:55
@PavelVPV PavelVPV marked this pull request as ready for review May 12, 2025 07:55
@github-actions github-actions bot added area: Bluetooth area: Bluetooth Host Bluetooth Host (excluding BR/EDR) labels May 12, 2025
@sonarqubecloud
Copy link

@Thalley
Copy link
Contributor

Thalley commented May 12, 2025

What if other controllers do this?

@PavelVPV
Copy link
Contributor Author

What if other controllers do this?

This was specifically added for SDC. I don't know if other controllers do this.

Also, this approach showed that regardless of number of internal ACL buffers Host ends up in a situation where it has less buffers than Controller thinks Host has. IOW, it always ends up in desynchronization of number of ACL buffers on Host side between Host and Controller. It is neither possible to predict future and stop reporting HNCP to avoid desynchronization, because this in turns will lead to a deadlock between Host and Controller when one needs buffers to complete recombination and the other needs HNCP to to send the disconnection event.

@fabiobaltieri fabiobaltieri merged commit 971c2c9 into zephyrproject-rtos:main May 14, 2025
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area: Bluetooth Host Bluetooth Host (excluding BR/EDR) area: Bluetooth

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants