drivers: Add analog pins for nRF54L20 #89609
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
platform: NXP Drivers
github-actions
bot
requested review from
Raymond0225,
anangl,
bjarki-andreasen,
dbaluta,
decsny,
dleach02,
jaz1-nordic,
kl-cruz,
magp-nordic,
manuargue,
masz-nordic,
mmahadevan108 and
nika-nordic
mstasiaknordic
force-pushed
the
nrf54l20_ain
branch
from
5628e65 to
7a0420b
Compare
Member
|
why is nxp platforms added by the bot? |
decsny
removed request for
Raymond0225,
dbaluta,
decsny,
dleach02,
manuargue and
mmahadevan108
mstasiaknordic
force-pushed
the
nrf54l20_ain
branch
from
7a0420b to
984715f
Compare
mstasiaknordic
force-pushed
the
nrf54l20_ain
branch
from
1f4364e to
de9284d
Compare
bjarki-andreasen
previously approved these changes
May 8, 2025
anangl
previously approved these changes
May 8, 2025
mstasiaknordic
dismissed stale reviews from anangl and bjarki-andreasen
via
2dad686
mstasiaknordic
force-pushed
the
nrf54l20_ain
branch
from
de9284d to
2dad686
Compare
Contributor
Author
|
@bjarki-andreasen I moved the array of analog pins to common file. Since the comparator can be used only as either COMP or LPCOMP at the same time, this should not cause any problems. Please take a look |
mstasiaknordic
force-pushed
the
nrf54l20_ain
branch
from
2dad686 to
3e221f7
Compare
bjarki-andreasen
requested changes
May 9, 2025
|
|
||
| #ifndef ZEPHYR_DRIVERS_COMPARATOR_NRF_COMMON_H_ | ||
| #define ZEPHYR_DRIVERS_COMPARATOR_NRF_COMMON_H_ | ||
|
|
Contributor
There was a problem hiding this comment.
please #include <nrfx.h> here, otherwise we need to rely on include order to ensure NRF_PIN_PORT_TO_PIN_NUMBER is defined :)
mstasiaknordic
force-pushed
the
nrf54l20_ain
branch
from
3e221f7 to
9799ae0
Compare
anangl
reviewed
May 9, 2025
tests/boards/nrf/comp/Kconfig
Outdated
| # SPDX-License-Identifier: Apache-2.0 | ||
|
|
||
| config TEST_COMP_SE_PSEL_AIN_INDEX | ||
| int "Index od analog input for SE psel." |
Member
There was a problem hiding this comment.
The typos here ("od") could also be corrected.
mstasiaknordic
force-pushed
the
nrf54l20_ain
branch
from
9799ae0 to
b715006
Compare
anangl
approved these changes
May 9, 2025
kl-cruz
approved these changes
May 12, 2025
nika-nordic
approved these changes
May 12, 2025
mstasiaknordic
force-pushed
the
nrf54l20_ain
branch
from
b715006 to
283a59a
Compare
Added set of analog pins for nRF54L20 SAADC. Signed-off-by: Michał Stasiak <michal.stasiak@nordicsemi.no>
Added set of analog pins for nRF54L20 COMP and LPCOMP. Moved the array of analong pins for both comparator variants to avoid code duplication. Signed-off-by: Michał Stasiak <michal.stasiak@nordicsemi.no>
Moved index of analog input used in test from source code to Kconfig option to simplify adding new targets. Signed-off-by: Michał Stasiak <michal.stasiak@nordicsemi.no>
mstasiaknordic
force-pushed
the
nrf54l20_ain
branch
from
283a59a to
ca3942b
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added set of analog pins for nRF54L20 SAADC, COMP and LPCOMP.