net: lwm2m: Fix blockwise Ack NUM calculation #89665
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
After the PR zephyrproject-rtos#85000 the calculation of NUM field of Block 1 option on CoAP Ack packet started to advance to next packet block. We should not update the ctx->current field because it is used for calculating the NUM field in response packet. It should point to beginning of the payload, so the response is correct. Leshan server don't seem to care about this, but Coiote does. Signed-off-by: Seppo Takalo <seppo.takalo@nordicsemi.no>
There was a problem hiding this comment.
Pull Request Overview
This PR addresses an issue with the blockwise Ack NUM calculation on CoAP packets by removing an update to the block context pointer.
- Removed the modification of ctx->current in lwm2m_write_handler_opaque to ensure it points to the payload beginning.
Comments suppressed due to low confidence (1)
subsys/net/lib/lwm2m/lwm2m_message_handling.c:1059
- The removal of the block context update appears to be the fix per the PR description, but consider adding an inline comment to clarify that this update was removed to correctly calculate the NUM field for CoAP Ack packets (referencing PR #85000 for context).
if (msg->in.block_ctx && !last_pkt_block) {
rlubos
approved these changes
May 8, 2025
jukkar
approved these changes
May 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After the PR #85000 the calculation of NUM field of Block 1 option on CoAP Ack packet started to advance to next packet block.
We should not update the ctx->current field because it is used for calculating the NUM field in response packet. It should point to beginning of the payload,
so the response is correct.
Leshan server don't seem to care about this, but Coiote does.