Add IPC memory and mailbox chosen properties for Beagle #89678
Conversation
Add IPC memory and mailbox chosen properties. The mailbox channels used are as expected by Linux. Signed-off-by: Andrew Davis <afd@ti.com>
Add IPC memory and mailbox chosen properties. The mailbox channels used are as expected by Linux. Signed-off-by: Andrew Davis <afd@ti.com>
Add IPC memory and mailbox chosen properties. The mailbox channels used are as expected by Linux. Signed-off-by: Andrew Davis <afd@ti.com>
github-actions
bot
requested review from
Ayush1325,
con-pax,
jadonk and
vaishnavachath
|
| ipc0: ipc { | ||
| compatible = "zephyr,mbox-ipm"; | ||
| mboxes = <&mbox1 0>, <&mbox1 1>; | ||
| mbox-names = "tx", "rx"; |
There was a problem hiding this comment.
This is from the perspective of the MCU, correct? Unclear if this is a convention, but a definition that provides source and destination would be more clear.
There was a problem hiding this comment.
This is always from the perspective of the DTS in which these are defined. So this being the R5 DTS means tx is tx from R5. In the A53 DTS the tx is tx from A53, which would mean the mboxes would be reversed.
But yes I agree tx/rx are usually useless in identifying direction, especially on board connectors like in UART cases. In this case though "host_send" and "client_receive", or something to that effect, would not be clear either due to not defining who is the host/client in the scenario (and it can actually change, R5 can be the host, A53 the client, and vice versa based on task). "r5_send_mbox" might work, but then it wouldn't be symmetric with the other side DTS names, nor portable :(
5 participants
These selections are used by applications using the OpenAMP IPC frameworks. Add these here to allow those applications and the examples[0] to work out-of-box without needing additional overlays.
[0] https://github.com/zephyrproject-rtos/zephyr/tree/main/samples/subsys/ipc