drivers: iom: define ambiq spi/i2c dma mode as a binding property #89693
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR changes the DMA configuration for Ambiq SPI/I2C drivers from compile‐time Kconfig macros to a binding property, allowing more flexibility for different instances.
- Added a new binding property "dma-mode" in the DTS YAML file.
- Updated SPI and I2C drivers to use the new property instead of CONFIG_* macros.
- Removed corresponding DMA options from Kconfig files.
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| dts/bindings/mfd/ambiq,iom.yaml | Added "dma-mode" property for enabling DMA and updated command queue size description. |
| drivers/spi/spi_ambiq_spic.c | Introduced the dma_mode field, revised transfer logic and interrupt setup based on dma_mode. |
| drivers/spi/Kconfig.ambiq | Removed the SPI DMA configuration option to use the new binding property instead. |
| drivers/i2c/i2c_ambiq.c | Introduced the dma_mode field and updated transfer functions to handle DMA or blocking transfers accordingly. |
| drivers/i2c/Kconfig.ambiq | Removed the I2C DMA configuration option in favor of the binding property. |
AlessandroLuo
force-pushed
the
ambiq-iom-dma
branch
3 times, most recently
from
e952c91 to
5def355
Compare
Changed to define ambiq spi/i2c dma mode as a binding property instead of kconfig macros, making it more flexible for different spi/i2c instances. Signed-off-by: Hao Luo <hluo@ambiq.com>
AlessandroLuo
force-pushed
the
ambiq-iom-dma
branch
from
5def355 to
1f98488
Compare
|
github-actions
bot
added
platform: Ambiq
github-actions
bot
requested review from
RichardSWheatley,
aaronyegx,
aasinclair,
tbursztyka and
teburd
aaronyegx
approved these changes
May 9, 2025
RichardSWheatley
approved these changes
May 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed to define ambiq spi/i2c dma mode as a binding property instead of kconfig macros, making it more flexible for different spi/i2c instances.