soc: nordic: nrf54l: Clean up internal capacitance calculations. #89710
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mstasiaknordic
force-pushed
the
nrf54l_lfxo_cap
branch
from
50c7c20 to
6e6734a
Compare
mstasiaknordic
changed the title
github-actions
bot
requested review from
anangl,
jaz1-nordic,
kl-cruz,
magp-nordic,
masz-nordic and
nika-nordic
mstasiaknordic
force-pushed
the
nrf54l_lfxo_cap
branch
2 times, most recently
from
db1b331 to
ffa2c9b
Compare
anangl
requested changes
May 9, 2025
soc/nordic/nrf54l/soc.c
Outdated
Comment on lines
85
to
88
| uint32_t lfxo_intcap = (lfxo_intcap_mid_val >> 9UL) / 1000UL; | ||
|
|
||
| /* Round based on fractional part */ | ||
| if ((mid_val & BIT_MASK(9)) > (BIT_MASK(9) / 2)) { | ||
| /* Round based on fractional part. */ | ||
| if (lfxo_intcap_mid_val % 1000 >= 500) { |
Member
There was a problem hiding this comment.
This rounding is incorrect, since lfxo_intcap is lfxo_intcap_mid_val divided by 512000, not by 1000.
Contributor
Author
There was a problem hiding this comment.
You are right, corrected.
soc/nordic/nrf54l/soc.c
Outdated
|
|
||
| /* Get integer part of the INTCAP code */ | ||
| uint32_t lfxo_intcap = mid_val >> 9UL; | ||
| /* Get integer part of the INTCAP code and concert to pico Farads. */ |
soc/nordic/nrf54l/soc.c
Outdated
|
|
||
| /* Convert the calculated value to piko Farads */ | ||
| uint32_t hfxo_intcap = mid_val_intcap / 1000; | ||
| /* Convert the calculated value to pikc Farads. */ |
mstasiaknordic
force-pushed
the
nrf54l_lfxo_cap
branch
from
ffa2c9b to
18d9377
Compare
anangl
reviewed
May 9, 2025
soc/nordic/nrf54l/soc.c
Outdated
| /* Get integer part of the INTCAP code */ | ||
| uint32_t lfxo_intcap = mid_val >> 9UL; | ||
| /* Get integer part of the INTCAP code and convert to pico Farads. */ | ||
| uint32_t lfxo_intcap = (lfxo_intcap_mid_val >> 9UL) / 1000UL; |
Member
There was a problem hiding this comment.
Just to make the rounding that follows a bit more obvious.
Suggested change
| uint32_t lfxo_intcap = (lfxo_intcap_mid_val >> 9UL) / 1000UL; | |
| uint32_t lfxo_intcap = lfxo_intcap_mid_val / 512000UL; |
Code responsible for internal capacitor values containted leftover workarounds in the calculations after PS update. Removed redundant conversions and cleaned up both code and comments to align both LFXO and HFXO calculation. Signed-off-by: Michał Stasiak <michal.stasiak@nordicsemi.no>
mstasiaknordic
force-pushed
the
nrf54l_lfxo_cap
branch
from
18d9377 to
b9516db
Compare
anangl
approved these changes
May 9, 2025
nika-nordic
approved these changes
May 9, 2025
kl-cruz
approved these changes
May 9, 2025
adamkondraciuk
approved these changes
May 9, 2025
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Code responsible for internal capacitor values containted leftover workarounds in the calculations after PS update. Removed redundant conversions and cleaned up both code and comments to align both LFXO and HFXO calculation.