cmake: fix syscall dependencies #89731
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
57300,
jeremybettis,
nashif,
nordicjm and
tejlmand
tejlmand
approved these changes
May 9, 2025
Contributor
|
Thanks for fixing this. |
pdgendt
approved these changes
May 9, 2025
nordicjm
requested changes
May 12, 2025
Contributor
nordicjm
left a comment
nordicjm
left a comment
There was a problem hiding this comment.
Fix is OK but please remove the fixes part from the git commit description, as per contribution guidelines
Replace _parse_syscalls_target_ custom target with explicit dependency management for syscall depending file generation. Signed-off-by: David Schneider <schneidav81@gmail.com>
dsch
force-pushed
the
fix-syscall-header-dependencies
branch
from
d0aaaef to
955ac71
Compare
|
nordicjm
approved these changes
May 13, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace parse_syscalls_target custom target with explicit dependency management for syscall depending file generation.
Fixes #89729