style: add missing curly braces in if/while/for statements. #89735
Conversation
github-actions
bot
requested review from
JiafeiPan,
Raymond0225,
SgrrZhf,
carlocaione,
dbaluta,
decsny,
dleach02,
ithinuel,
manuargue,
mmahadevan108,
npitre,
povergoing,
ruuddw,
teburd and
wearyzen
|
arch/arc/core/prep_c.c
Outdated
| ARC_CLN_CACHE_CMD_OP_REG_INV | ARC_CLN_CACHE_CMD_INCR); | ||
| while (arc_cln_read_reg_nolock(ARC_CLN_CACHE_STATUS) & ARC_CLN_CACHE_STATUS_BUSY) | ||
| while (arc_cln_read_reg_nolock(ARC_CLN_CACHE_STATUS) & ARC_CLN_CACHE_STATUS_BUSY) { | ||
| ; |
There was a problem hiding this comment.
Do we allow these empty statements (;)? SonarQube flags them for removal. I'd prefer either empty braces (or otherwise empty braces with a comment in them) or terminating the loop as while (...);
There was a problem hiding this comment.
yeah, just noticed that, will deal with it. Thanks.
Add missing curly braces in if/while/for statements. This is a style guideline we have that was not enforced in CI. All issues fixed here were detected by sonarqube SCA. Signed-off-by: Anas Nashif <anas.nashif@intel.com>
ruuddw
left a comment
ruuddw
left a comment
There was a problem hiding this comment.
SonarQube or some agent may be better in reviewing this than me, but looks good to me :-)
| chan_data = &dev_data->chan[channel]; | ||
|
|
||
| if (!size) | ||
| if (!size) { |
There was a problem hiding this comment.
nit, as existing: as you're already changing the line, consider changing it to "size == 0" to make it clear that size isn't a boolean.
6 participants
Add missing curly braces in if/while/for statements.
This is a style guideline we have that was not enforced in CI. All
issues fixed here were detected by sonarqube SCA.
Signed-off-by: Anas Nashif anas.nashif@intel.com